Skip to content

[Feature] Remove old ui.#9909

Merged
songjianet merged 2 commits intoapache:devfrom
songjianet:feat-remove-old-ui
May 6, 2022
Merged

[Feature] Remove old ui.#9909
songjianet merged 2 commits intoapache:devfrom
songjianet:feat-remove-old-ui

Conversation

@songjianet
Copy link
Copy Markdown
Member

@songjianet songjianet commented May 6, 2022

Purpose of the pull request

close #9896

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@songjianet songjianet added feature new feature UI ui and front end related backend CI&CD document labels May 6, 2022
@songjianet songjianet self-assigned this May 6, 2022
kezhenxu94
kezhenxu94 previously approved these changes May 6, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTM

Amy0104
Amy0104 previously approved these changes May 6, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@Amy0104 Amy0104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

devosend
devosend previously approved these changes May 6, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@devosend devosend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhongjiajie
zhongjiajie reviewed May 6, 2022
View reviewed changes
docs/docs/en/development/development-environment-setup.md

```shell
cd dolphinscheduler-ui-next
cd dolphinscheduler-ui
Copy link
Copy Markdown
Member

@zhongjiajie zhongjiajie May 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should also change Chinese docs in https://dolphinscheduler.apache.org/zh-cn/development/development-environment-setup.html, BTW, should we also need to remove content in https://dolphinscheduler.apache.org/en-us/development/frontend-development.html because in out of date now

Copy link
Copy Markdown
Member

@zhongjiajie zhongjiajie May 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chinese file link is https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/zh/development/development-environment-setup.md

@songjianet songjianet dismissed stale reviews from devosend, Amy0104, and kezhenxu94 via ec37f7b May 6, 2022 04:30
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 6, 2022

Codecov Report

Merging #9909 (ec37f7b) into dev (693b8a9) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev    #9909   +/-   ##
=========================================
  Coverage     40.32%   40.32%           
  Complexity     4532     4532           
=========================================
  Files           835      835           
  Lines         33747    33747           
  Branches       3726     3726           
=========================================
  Hits          13607    13607           
  Misses        18853    18853           
  Partials       1287     1287

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 693b8a9...ec37f7b. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented May 6, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 26 Security Hotspots
Code Smell A 413 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@zhongjiajie
Copy link
Copy Markdown
Member

zhongjiajie commented May 6, 2022

I restart the failed CI

zhongjiajie
zhongjiajie approved these changes May 6, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

labbomb
labbomb approved these changes May 6, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@labbomb labbomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songjianet songjianet merged commit 7a7807e into apache:dev May 6, 2022
This was referenced May 7, 2022
Merged
Merged
Closed
@songjianet songjianet deleted the feat-remove-old-ui branch May 9, 2022 12:10
@zhongjiajie zhongjiajie mentioned this pull request May 20, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@labbomb labbomb labbomb approved these changes

@zhongjiajie zhongjiajie zhongjiajie approved these changes

@devosend devosend devosend left review comments

@kezhenxu94 kezhenxu94 kezhenxu94 left review comments

@Amy0104 Amy0104 Amy0104 left review comments

Assignees

@songjianet songjianet

Labels

backend CI&CD document feature new feature UI ui and front end related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature][UI] Remove old UI .

7 participants

@songjianet @codecov-commenter @zhongjiajie @devosend @labbomb @kezhenxu94 @Amy0104