[python] Support read config in env variable#9517
Merged
devosend merged 1 commit intoapache:devfrom Apr 15, 2022
Merged
Conversation
Add a new method to get config from environment variables and for now, we have three ways to get config and the priority is `env-var > custom-config-file > built-in-config-file`. Environment config setting does not work in CLI, because it will confuse users when they get config value is `var-env` but value in the configuration file is `var-in-file`, they may not find the way how to change it * Add documentation * Add it to UPDATING.md close: apache#8344
Codecov Report
@@ Coverage Diff @@
## dev #9517 +/- ##
============================================
- Coverage 39.90% 39.90% -0.01%
+ Complexity 4418 4415 -3
============================================
Files 826 826
Lines 33258 33253 -5
Branches 3683 3683
============================================
- Hits 13272 13270 -2
+ Misses 18754 18752 -2
+ Partials 1232 1231 -1
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new method to get config from environment variables
and for now, we have three ways to get config and the
priority is
env-var > custom-config-file > built-in-config-file.Environment config setting does not work in CLI, because it will
confuse users when they get config value is
var-envbut valuein the configuration file is
var-in-file, they may not findthe way how to change it
close: #8344