Skip to content

[python] Add config mechanism and cli subcommand config#8585

Merged
songjianet merged 2 commits intoapache:devfrom
zhongjiajie:py-add-local-config-file
Mar 1, 2022
Merged

[python] Add config mechanism and cli subcommand config#8585
songjianet merged 2 commits intoapache:devfrom
zhongjiajie:py-add-local-config-file

Conversation

@zhongjiajie
Copy link
Copy Markdown
Member

  • Add configuration.py mechanism for more easy change config
    and move some configs to it. It mechanism including
    configuration.py module and default_config.yaml file
  • Add config for cli subcommand allow users initialize, get,
    set configs

close: #8344

* Add configuration.py mechanism for more easy change config
  and move some configs to it. It mechanism including
  configuration.py module and default_config.yaml file
* Add `config` for cli subcommand allow users initialize, get,
  set configs

close: apache#8344
@zhongjiajie
Copy link
Copy Markdown
Member Author

PTAL @devosend @jieguangzhou thanks

@devosend
Copy link
Copy Markdown
Contributor

devosend commented Mar 1, 2022

LGTM

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Copy Markdown
Member

@songjianet songjianet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songjianet songjianet merged commit ec4ce2b into apache:dev Mar 1, 2022
@zhongjiajie zhongjiajie deleted the py-add-local-config-file branch March 1, 2022 03:58
@zhongjiajie
Copy link
Copy Markdown
Member Author

Thanks

@zhongjiajie
Copy link
Copy Markdown
Member Author

This PR target to the wrong issue, is should close issue #8249 instead of #8344

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][python] Support read configuration in env variable

3 participants