[python] Fix python api can't connect to remote gateway server#8248
Merged
zhongjiajie merged 5 commits intoapache:devfrom Jan 29, 2022
Merged
[python] Fix python api can't connect to remote gateway server#8248zhongjiajie merged 5 commits intoapache:devfrom
zhongjiajie merged 5 commits intoapache:devfrom
Conversation
For now, python API could only communicate python gateway server in the same hosts, this patch makes it could work with different hosts, and export java gateway setting to configure file
c732977 to
7d82cf4
Compare
Member
Author
|
I've already test in my server and it work. |
3 tasks
kezhenxu94
reviewed
Jan 29, 2022
...inscheduler-python/src/main/java/org/apache/dolphinscheduler/server/PythonGatewayServer.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## dev #8248 +/- ##
============================================
+ Coverage 44.94% 45.18% +0.23%
- Complexity 3950 3983 +33
============================================
Files 672 678 +6
Lines 26182 26343 +161
Branches 2825 2836 +11
============================================
+ Hits 11768 11902 +134
- Misses 13304 13318 +14
- Partials 1110 1123 +13
Continue to review full report at Codecov.
|
Member
|
Others LGTM |
ruanwenjun
reviewed
Jan 29, 2022
...uler-python/src/main/java/org/apache/dolphinscheduler/server/config/PythonGatewayConfig.java
Show resolved
Hide resolved
…ler/server/PythonGatewayServer.java Co-authored-by: kezhenxu94 <kezhenxu94@apache.org>
Member
Author
|
Changed base on some suggestions, PTAL @kezhenxu94 @ruanwenjun thanks |
|
SonarCloud Quality Gate failed. |
Member
Author
|
Thanks ~ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now, python API could only communicate python gateway server
in the same hosts, this patch makes it could work with different hosts,
and export java gateway setting to configure file