Skip to content

[python] Initiate document for pydolphinscheduler#8005

Merged
kezhenxu94 merged 22 commits intoapache:devfrom
zhongjiajie:py-doc-init
Jan 26, 2022
Merged

[python] Initiate document for pydolphinscheduler#8005
kezhenxu94 merged 22 commits intoapache:devfrom
zhongjiajie:py-doc-init

Conversation

@zhongjiajie
Copy link
Copy Markdown
Member

@zhongjiajie zhongjiajie commented Jan 13, 2022

ref: #6407

@zhongjiajie zhongjiajie self-assigned this Jan 13, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 13, 2022 •
edited
Loading

Codecov Report

Merging #8005 (872495c) into dev (435d378) will decrease coverage by 0.20%.
The diff coverage is 12.64%.

❗ Current head 872495c differs from pull request most recent head fa7e8cb. Consider uploading reports for the commit fa7e8cb to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #8005      +/-   ##
============================================
- Coverage     41.49%   41.29%   -0.21%     
- Complexity     3735     3743       +8     
============================================
  Files           637      642       +5     
  Lines         27176    27401     +225     
  Branches       3092     3116      +24     
============================================
+ Hits          11278    11314      +36     
- Misses        14811    14998     +187     
- Partials       1087     1089       +2
Impacted Files Coverage Δ
...ugin/alert/pagerduty/PagerDutyParamsConstants.java 0.00% <0.00%> (ø)
...ache/dolphinscheduler/common/enums/StateEvent.java 0.00% <0.00%> (ø)
.../dolphinscheduler/common/enums/StateEventType.java 0.00% <0.00%> (ø)
...ache/dolphinscheduler/dao/entity/TaskInstance.java 64.84% <0.00%> (+1.15%) ⬆️
.../server/master/runner/StateWheelExecuteThread.java 0.52% <0.00%> (-0.30%) ⬇️
...erver/master/runner/WorkflowExecuteThreadPool.java 0.00% <0.00%> (ø)
...r/server/master/runner/task/BaseTaskProcessor.java 4.96% <0.00%> (ø)
...ver/master/runner/task/ConditionTaskProcessor.java 5.26% <ø> (+0.06%) ⬆️
...ver/master/runner/task/DependentTaskProcessor.java 5.40% <ø> (+0.07%) ⬆️
...er/server/master/runner/task/SubTaskProcessor.java 6.17% <ø> (+0.07%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 435d378...fa7e8cb. Read the comment docs.

@zhongjiajie zhongjiajie changed the title [python] Initiate document for pydolphinscheduler [WIP][python] Initiate document for pydolphinscheduler Jan 14, 2022
@zhongjiajie zhongjiajie added the feature new feature label Jan 14, 2022
@zhongjiajie zhongjiajie mentioned this pull request Jan 14, 2022
Closed
30 tasks
@zhongjiajie zhongjiajie marked this pull request as ready for review January 25, 2022 11:31
@zhongjiajie zhongjiajie changed the title [WIP][python] Initiate document for pydolphinscheduler [python] Initiate document for pydolphinscheduler Jan 25, 2022
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@zhongjiajie
Copy link
Copy Markdown
Member Author

zhongjiajie commented Jan 25, 2022

@devosend PTAL, thanks

kezhenxu94
kezhenxu94 approved these changes Jan 26, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't dig deeper but if you copy some files from others (like SPHINX), make sure to keep their license header and address the license

@zhongjiajie
Copy link
Copy Markdown
Member Author

zhongjiajie commented Jan 26, 2022

I didn't dig deeper but if you copy some files from others (like SPHINX), make sure to keep their license header and address the license

Hi @kezhenxu94 , I am not copy-paste from sphinx, it just auto-generate by command sphinx-quickstart https://www.sphinx-doc.org/en/master/tutorial/getting-started.html#creating-the-documentation-layout . It just like a config file and I think is could directly use ASF license, WDYT?

@kezhenxu94 kezhenxu94 merged commit 35578ef into apache:dev Jan 26, 2022
@zhongjiajie zhongjiajie deleted the py-doc-init branch January 26, 2022 06:09
@zhongjiajie
Copy link
Copy Markdown
Member Author

zhongjiajie commented Jan 26, 2022

Thanks~

@devosend
Copy link
Copy Markdown
Contributor

devosend commented Jan 26, 2022

The doc looks great.

@zhongjiajie
Copy link
Copy Markdown
Member Author

zhongjiajie commented Jan 26, 2022

Thanks~

The doc looks great.

@zhongjiajie zhongjiajie mentioned this pull request Jan 27, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kezhenxu94 kezhenxu94 kezhenxu94 approved these changes

@caishunfeng caishunfeng Awaiting requested review from caishunfeng

Assignees

@zhongjiajie zhongjiajie

Labels

document feature new feature Pyscheduler

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhongjiajie @codecov-commenter @devosend @kezhenxu94