[Fix-7857] The user won't be allowed to disable their own account.#7891
Merged
zhuangchong merged 2 commits intoapache:devfrom Jan 8, 2022
Merged
[Fix-7857] The user won't be allowed to disable their own account.#7891zhuangchong merged 2 commits intoapache:devfrom
zhuangchong merged 2 commits intoapache:devfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #7891 +/- ##
============================================
- Coverage 41.00% 40.98% -0.02%
+ Complexity 3696 3694 -2
============================================
Files 637 637
Lines 27053 27057 +4
Branches 3072 3073 +1
============================================
- Hits 11092 11090 -2
- Misses 14891 14898 +7
+ Partials 1070 1069 -1
Continue to review full report at Codecov.
|
zhuangchong
reviewed
Jan 8, 2022
Contributor
zhuangchong
left a comment
There was a problem hiding this comment.
The user is not allowed to modify the status of his account, then the front-end display status is grayed out, and the back-end is also verified, I think this will have a better experience.
Contributor
Author
|
When editing someone's own user profile, the component of disabling user's state will never show up.
|
|
Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
This PR will close #7857 .
Brief change log
It's risky to disable some users' account by themselves. So rectify the codes not to allow user disable their own account.
Verify this pull request
This change added tests and can be verified as follows: