Skip to content

[Fix-7203] Remedy the issue about importing a process json file.#7811

Merged
zhuangchong merged 5 commits intoapache:devfrom
calvinjiang:f-import-process
Jan 5, 2022
Merged

[Fix-7203] Remedy the issue about importing a process json file.#7811
zhuangchong merged 5 commits intoapache:devfrom
calvinjiang:f-import-process

Conversation

@calvinjiang
Copy link
Copy Markdown
Contributor

Purpose of the pull request

This PR will close #7203 .

Brief change log

The original codes didn't deal with the part of locations in the process definition json.So when the user employs this function of importing a process definition file the system would lose the locations.

Verify this pull request

This change added tests and can be verified as follows:

  • Manually verified the change by testing locally.
    The original process is as follows:
    image

The imported process is as follows:
image

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 5, 2022

Codecov Report

Merging #7811 (b974568) into dev (ab89e43) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #7811      +/-   ##
============================================
- Coverage     40.89%   40.89%   -0.01%     
- Complexity     3671     3673       +2     
============================================
  Files           637      637              
  Lines         26783    26795      +12     
  Branches       3017     3020       +3     
============================================
+ Hits          10954    10958       +4     
- Misses        14776    14783       +7     
- Partials       1053     1054       +1     
Impacted Files Coverage Δ
...api/service/impl/ProcessDefinitionServiceImpl.java 25.38% <0.00%> (-0.32%) ⬇️
...he/dolphinscheduler/common/enums/SqoopJobType.java 0.00% <0.00%> (-88.89%) ⬇️
...r/plugin/registry/zookeeper/ZookeeperRegistry.java 48.21% <0.00%> (-7.15%) ⬇️
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...inscheduler/common/task/sqoop/SqoopParameters.java 74.00% <0.00%> (-2.00%) ⬇️
...dolphinscheduler/remote/future/ResponseFuture.java 81.96% <0.00%> (-1.64%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 53.52% <0.00%> (+1.40%) ⬆️
...org/apache/dolphinscheduler/remote/utils/Host.java 40.00% <0.00%> (+2.22%) ⬆️
...rver/master/processor/queue/TaskResponseEvent.java 100.00% <0.00%> (+6.45%) ⬆️
...er/master/processor/queue/TaskResponseService.java 68.18% <0.00%> (+18.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab89e43...b974568. Read the comment docs.

zhuangchong
zhuangchong previously approved these changes Jan 5, 2022
Copy link
Copy Markdown
Contributor

@zhuangchong zhuangchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 5, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Copy Markdown
Contributor

@zhuangchong zhuangchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zhuangchong zhuangchong merged commit f0ad65c into apache:dev Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [Process definition] There is a problem with the location of the import process node.

3 participants