Skip to content

[Fix-7775][DAO] ResourceDao's logger class is wrong#7776

Merged
zhuangchong merged 1 commit intoapache:devfrom
SbloodyS:bug_7775
Jan 4, 2022
Merged

[Fix-7775][DAO] ResourceDao's logger class is wrong#7776
zhuangchong merged 1 commit intoapache:devfrom
SbloodyS:bug_7775

Conversation

@SbloodyS
Copy link
Copy Markdown
Member

@SbloodyS SbloodyS commented Jan 3, 2022

Purpose of the pull request

close #7775

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 3, 2022

Codecov Report

Merging #7776 (0b07ca2) into dev (fa906e7) will decrease coverage by 0.11%.
The diff coverage is 15.00%.

❗ Current head 0b07ca2 differs from pull request most recent head d167efd. Consider uploading reports for the commit d167efd to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #7776      +/-   ##
============================================
- Coverage     40.95%   40.84%   -0.12%     
+ Complexity     3671     3668       -3     
============================================
  Files           642      642              
  Lines         26707    26740      +33     
  Branches       2997     3006       +9     
============================================
- Hits          10939    10923      -16     
- Misses        14716    14766      +50     
+ Partials       1052     1051       -1
Impacted Files Coverage Δ
...r/api/service/impl/ProcessInstanceServiceImpl.java 60.56% <0.00%> (-0.18%) ⬇️
...lphinscheduler/service/process/ProcessService.java 35.31% <0.00%> (-0.28%) ⬇️
...api/service/impl/ProcessDefinitionServiceImpl.java 25.70% <17.24%> (-0.53%) ⬇️
.../org/apache/dolphinscheduler/api/enums/Status.java 100.00% <100.00%> (ø)
...he/dolphinscheduler/common/enums/SqoopJobType.java 0.00% <0.00%> (-88.89%) ⬇️
...r/plugin/registry/zookeeper/ZookeeperRegistry.java 48.21% <0.00%> (-8.04%) ⬇️
...inscheduler/common/task/sqoop/SqoopParameters.java 74.00% <0.00%> (-2.00%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 53.52% <0.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa906e7...d167efd. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

zhuangchong
zhuangchong approved these changes Jan 4, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@zhuangchong zhuangchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zhuangchong zhuangchong merged commit f34dfe8 into apache:dev Jan 4, 2022
@SbloodyS SbloodyS deleted the bug_7775 branch January 4, 2022 01:42
@SbloodyS SbloodyS restored the bug_7775 branch January 4, 2022 01:54
@SbloodyS SbloodyS deleted the bug_7775 branch January 4, 2022 01:54
@SbloodyS SbloodyS mentioned this pull request Jan 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhuangchong zhuangchong zhuangchong approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] [DAO] ResourceDao's logger class is wrong

3 participants

@SbloodyS @codecov-commenter @zhuangchong