[Feature-7769][API] Add batch start process api#7771
Merged
zhongjiajie merged 14 commits intoapache:devfrom Jan 7, 2022
Merged
[Feature-7769][API] Add batch start process api#7771zhongjiajie merged 14 commits intoapache:devfrom
zhongjiajie merged 14 commits intoapache:devfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #7771 +/- ##
============================================
+ Coverage 41.03% 41.07% +0.04%
- Complexity 3696 3700 +4
============================================
Files 637 637
Lines 27025 27044 +19
Branches 3063 3067 +4
============================================
+ Hits 11090 11109 +19
+ Misses 14867 14864 -3
- Partials 1068 1071 +3
Continue to review full report at Codecov.
|
caishunfeng
reviewed
Jan 3, 2022
...heduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ExecutorController.java
Show resolved
Hide resolved
zhongjiajie
reviewed
Jan 4, 2022
...heduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ExecutorController.java
Outdated
Show resolved
Hide resolved
...heduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ExecutorController.java
Show resolved
Hide resolved
...heduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ExecutorController.java
Outdated
Show resolved
Hide resolved
...heduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ExecutorController.java
Outdated
Show resolved
Hide resolved
...heduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ExecutorController.java
Show resolved
Hide resolved
added 2 commits
January 5, 2022 17:30
Member
Author
|
@zhongjiajie RequestParam timeout can not set int as defaultValue.So I kept it as it was.Please review again.thx. |
zhongjiajie
reviewed
Jan 7, 2022
| } | ||
|
|
||
| /** | ||
| * batch execute process instance |
Member
There was a problem hiding this comment.
Please also add https://github.com/apache/dolphinscheduler/pull/7771/files#r778501392 to comment, thanks
Member
There was a problem hiding this comment.
BTW, please rebase to dev branch, we fix flaky test in our CI
Member
|
We still have discuss in #7771 (comment) |
|
SonarCloud Quality Gate failed. |
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
This pr will close #7769