Skip to content

[Improvement-6151] Performance optimization of DEPENDENT task#7725

Merged
caishunfeng merged 2 commits intoapache:devfrom
cmss-bfs:dev
Dec 30, 2021
Merged

[Improvement-6151] Performance optimization of DEPENDENT task#7725
caishunfeng merged 2 commits intoapache:devfrom
cmss-bfs:dev

Conversation

@wangyizhi1
Copy link
Copy Markdown
Member

@wangyizhi1 wangyizhi1 commented Dec 30, 2021

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 30, 2021 •
edited
Loading

Codecov Report

Merging #7725 (ddfc84a) into dev (0bc4f9b) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #7725      +/-   ##
============================================
- Coverage     41.10%   41.08%   -0.02%     
+ Complexity     3677     3673       -4     
============================================
  Files           642      642              
  Lines         26665    26665              
  Branches       2993     2993              
============================================
- Hits          10960    10955       -5     
- Misses        14656    14661       +5     
  Partials       1049     1049
Impacted Files Coverage Δ
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...org/apache/dolphinscheduler/remote/utils/Host.java 37.77% <0.00%> (-2.23%) ⬇️
...dolphinscheduler/remote/future/ResponseFuture.java 81.96% <0.00%> (-1.64%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 52.11% <0.00%> (-1.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bc4f9b...ddfc84a. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Dec 30, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

songjianet
songjianet approved these changes Dec 30, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@songjianet songjianet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

caishunfeng
caishunfeng approved these changes Dec 30, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@caishunfeng caishunfeng merged commit 52a7439 into apache:dev Dec 30, 2021
@zhongjiajie
Copy link
Copy Markdown
Member

zhongjiajie commented Dec 30, 2021

FYI @wangyizhi1 @caishunfeng @songjianet , this PR does not target #6151 , it causes issue #6151 still open. It would make our issue hard to maintain, please take care of this next time, thanks

@zhongjiajie
Copy link
Copy Markdown
Member

zhongjiajie commented Dec 30, 2021

We should use keyword fix #6151 or close: #6151 to target issue in PR

@zhongjiajie zhongjiajie mentioned this pull request Dec 30, 2021
Closed
@SbloodyS SbloodyS mentioned this pull request Jan 7, 2022
Merged
@wangyizhi1
Copy link
Copy Markdown
Member Author

wangyizhi1 commented Jan 7, 2022

We should use keyword fix #6151 or close: #6151 to target issue in PR

@zhongjiajie Sorry, i will take care of this next time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caishunfeng caishunfeng caishunfeng approved these changes

@songjianet songjianet songjianet approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wangyizhi1 @codecov-commenter @zhongjiajie @caishunfeng @songjianet