Skip to content

[Improvement][MasterServer] event response handle parallel #7560

Merged
caishunfeng merged 25 commits intoapache:2.0.2-preparefrom
zwZjut:#7450
Dec 24, 2021
Merged

[Improvement][MasterServer] event response handle parallel #7560
caishunfeng merged 25 commits intoapache:2.0.2-preparefrom
zwZjut:#7450

Conversation

@zwZjut
Copy link
Copy Markdown
Contributor

@zwZjut zwZjut commented Dec 22, 2021 •
edited
Loading

Purpose of the pull request

#7450

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

zwZjut and others added 12 commits December 13, 2021 10:24
@zwZjut
[Feature][dolphinscheduler-api] parse traceId in http header for Cros…
2f26f5f 
…s system delivery to #7237 (#7238)

* to #7237

* rerun test

Co-authored-by: honghuo.zw <honghuo.zw@alibaba-inc.com>
@zwZjut
chery-pick 05aef27 and handle conflicts
4a90027
@zwZjut
to #7065: fix ExecutorService and schedulerService (#7072)
9c45a4f 
Co-authored-by: honghuo.zw <honghuo.zw@alibaba-inc.com>
@zwZjut
[Feature][dolphinscheduler-api] access control of taskDefinition and …
6897517 
…taskInstance in project to #7081  (#7082)

* to #7081

* fix #7081

* to #7081

Co-authored-by: honghuo.zw <honghuo.zw@alibaba-inc.com>
@zwZjut
chery-pick 8ebe060 and handle conflicts
6f491e4
@zwZjut
cherry-pick 1f18444 and handle conflicts
1bcde64
@zwZjut @CalvinKirs
fix #6807: dolphinscheduler.zookeeper.env_vars - > dolphinscheduler.r…
9cddad9 
…egistry.env_vars (#6808)

Co-authored-by: honghuo.zw <honghuo.zw@alibaba-inc.com>
Co-authored-by: Kirs <acm_master@163.com>
@zwZjut
add default constructor (#6780)
70ec96a 
Co-authored-by: honghuo.zw <honghuo.zw@alibaba-inc.com>
@zwZjut
to #7108 (#7109)
c79acd1
Merge branch '2.0.2-prepare' of https://github.com/zwZjut/dolphinsche…
6c29e89 
…duler into 2.0.2-prepare
Merge branch '2.0.2-prepare' of https://github.com/zwZjut/dolphinsche…
3367f56 
…duler into 2.0.2-prepare
to #7450
152bee0
@zwZjut zwZjut changed the base branch from dev to 2.0.2-prepare December 22, 2021 19:55
@zwZjut zwZjut changed the title #7450 [Improvement][MasterServer] event response handle parallel Dec 23, 2021
caishunfeng
caishunfeng approved these changes Dec 23, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

geosmart
geosmart reviewed Dec 24, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@geosmart geosmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add naming review

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 24, 2021 •
edited
Loading

Codecov Report

❌ Patch coverage is 11.11111% with 144 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (2.0.2-prepare@1693405). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ter/processor/queue/TaskResponsePersistThread.java 0.00% 85 Missing ⚠️
...er/master/processor/queue/TaskResponseService.java 28.81% 40 Missing and 2 partials ⚠️
...er/server/master/runner/FailoverExecuteThread.java 0.00% 11 Missing ⚠️
...inscheduler/server/master/config/MasterConfig.java 0.00% 3 Missing ⚠️
...r/server/master/registry/MasterRegistryClient.java 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@               Coverage Diff                @@
##             2.0.2-prepare    #7560   +/-   ##
================================================
  Coverage                 ?   31.46%           
  Complexity               ?     1561           
================================================
  Files                    ?      434           
  Lines                    ?    14810           
  Branches                 ?     1478           
================================================
  Hits                     ?     4660           
  Misses                   ?     9697           
  Partials                 ?      453

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Dec 24, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug E 24 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 3 Security Hotspots
Code Smell A 321 Code Smells

16.8% 16.8% Coverage
0.9% 0.9% Duplication

@caishunfeng caishunfeng merged commit f8942bf into apache:2.0.2-prepare Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caishunfeng caishunfeng caishunfeng approved these changes

+1 more reviewer

@geosmart geosmart geosmart left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zwZjut @codecov-commenter @geosmart @caishunfeng