[cherry-pick-7221/7232] pick some api bug#7234
Merged
lenboo merged 5 commits intoapache:2.0.1-preparefrom Dec 7, 2021
Merged
Conversation
…duler into 201-workergroup merge from 201-prepare
Codecov Report
@@ Coverage Diff @@
## 2.0.1-prepare #7234 +/- ##
================================================
Coverage ? 32.19%
Complexity ? 1570
================================================
Files ? 432
Lines ? 14484
Branches ? 1438
================================================
Hits ? 4663
Misses ? 9359
Partials ? 462 Continue to review full report at Codecov.
|
|
SonarCloud Quality Gate failed. |
lenboo
reviewed
Dec 7, 2021
|
|
||
| int update = taskDefinitionMapper.updateById(taskDefinition); | ||
| int updateLog = taskDefinitionLogMapper.updateById(taskDefinitionLog); | ||
| if ((update == 0 && updateLog == 1) || (update == 1 && updateLog == 0)) { |
Contributor
There was a problem hiding this comment.
is this can be changed to (update & updateLog)
Contributor
Author
There was a problem hiding this comment.
This way can not distinguish between all 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.