Skip to content

[DS-5229][feat] Implement server port custom config#6947

Merged
davidzollo merged 11 commits intoapache:devfrom
Lucaszlei:dev
Nov 30, 2021
Merged

[DS-5229][feat] Implement server port custom config#6947
davidzollo merged 11 commits intoapache:devfrom
Lucaszlei:dev

Conversation

@Lucaszlei
Copy link
Copy Markdown
Contributor

@Lucaszlei Lucaszlei commented Nov 22, 2021

[DS-5229][feat] Implement server port custom config
This closes #5229

Lucaszlei and others added 6 commits November 21, 2021 21:47
@zhuangchong zhuangchong added the first time contributor First-time contributor label Nov 22, 2021
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 22, 2021 •
edited
Loading

Codecov Report

Merging #6947 (f2de93d) into dev (e51a2a1) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #6947      +/-   ##
============================================
- Coverage     32.86%   32.86%   -0.01%     
  Complexity     1625     1625              
============================================
  Files           432      432              
  Lines         14382    14383       +1     
  Branches       1446     1446              
============================================
  Hits           4727     4727              
- Misses         9201     9202       +1     
  Partials        454      454
Impacted Files Coverage Δ
.../org/apache/dolphinscheduler/common/Constants.java 80.00% <ø> (ø)
...e/dolphinscheduler/server/worker/WorkerServer.java 0.00% <0.00%> (ø)
...ler/server/worker/processor/TaskKillProcessor.java 0.00% <0.00%> (ø)
...lphinscheduler/service/process/ProcessService.java 38.30% <0.00%> (ø)
...ache/dolphinscheduler/server/log/LoggerServer.java 85.71% <100.00%> (ø)
...he/dolphinscheduler/server/utils/ProcessUtils.java 37.34% <100.00%> (+0.76%) ⬆️
...inscheduler/common/task/sqoop/SqoopParameters.java 74.00% <0.00%> (-2.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e51a2a1...f2de93d. Read the comment docs.

davidzollo
davidzollo reviewed Nov 22, 2021
View reviewed changes
@Lucaszlei Lucaszlei requested a review from davidzollo November 23, 2021 12:50
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 30, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 60 Code Smells

20.9% 20.9% Coverage
3.1% 3.1% Duplication

@kezhenxu94
Copy link
Copy Markdown
Member

kezhenxu94 commented Nov 30, 2021

It is better to put the config item in https://github.com/apache/dolphinscheduler/blob/dev/dolphinscheduler-alert/dolphinscheduler-alert-server/src/main/resources/application-alert.yaml

@davidzollo
Copy link
Copy Markdown
Contributor

davidzollo commented Nov 30, 2021

It is better to put the config item in https://github.com/apache/dolphinscheduler/blob/dev/dolphinscheduler-alert/dolphinscheduler-alert-server/src/main/resources/application-alert.yaml

yes, you can submit another PR

all in all, thanks for your first contribution, it's a good beginning, good luck

davidzollo
davidzollo approved these changes Nov 30, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
good job

@davidzollo davidzollo added this to the 2.0.1-release milestone Nov 30, 2021
@davidzollo davidzollo merged commit 0dcff14 into apache:dev Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidzollo davidzollo davidzollo approved these changes

Assignees

No one assigned

Labels

first time contributor First-time contributor

Projects

None yet

Milestone

2.1.0

Development

Successfully merging this pull request may close these issues.

[Feature][server port] server port custom config

8 participants

@Lucaszlei @codecov-commenter @kezhenxu94 @davidzollo @lenboo @zhuangchong @GaoTianDuo @caishunfeng