Skip to content

[ci][python] Add isort to sort Python API imports#6871

Merged
CalvinKirs merged 1 commit intoapache:devfrom
zhongjiajie:ci-isort
Nov 17, 2021
Merged

[ci][python] Add isort to sort Python API imports#6871
CalvinKirs merged 1 commit intoapache:devfrom
zhongjiajie:ci-isort

Conversation

@zhongjiajie
Copy link
Copy Markdown
Member

This patch closes: #6860, import could be auto sort after this patch merge, and error when not sort

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #6871 (3ba90a0) into dev (94352a4) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #6871      +/-   ##
============================================
+ Coverage     33.07%   33.12%   +0.04%     
  Complexity     1619     1619              
============================================
  Files           433      433              
  Lines         14292    14292              
  Branches       1427     1427              
============================================
+ Hits           4727     4734       +7     
+ Misses         9116     9106      -10     
- Partials        449      452       +3     
Impacted Files Coverage Δ
...dolphinscheduler/remote/future/ResponseFuture.java 81.35% <0.00%> (-1.70%) ⬇️
...r/plugin/registry/zookeeper/ZookeeperRegistry.java 54.54% <0.00%> (+7.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94352a4...3ba90a0. Read the comment docs.

* Add isort config file to fix conflict with black
* Add some doc about isort
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@zhongjiajie zhongjiajie changed the title [WIP][ci][python] Add isort to sort Python API imports [ci][python] Add isort to sort Python API imports Nov 17, 2021
@zhongjiajie
Copy link
Copy Markdown
Member Author

It's good to go now,PTAL @CalvinKirs @lenboo

Copy link
Copy Markdown
Member

@CalvinKirs CalvinKirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CalvinKirs CalvinKirs merged commit 7c5c7ec into apache:dev Nov 17, 2021
@zhongjiajie zhongjiajie deleted the ci-isort branch November 17, 2021 03:51
@zhongjiajie
Copy link
Copy Markdown
Member Author

Thanks~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][python] Add auto sort import package

3 participants