Skip to content

[python] Add flake8 and black for code style and integrated to GA#6679

Merged
CalvinKirs merged 8 commits intoapache:devfrom
zhongjiajie:py-code-style
Nov 5, 2021
Merged

[python] Add flake8 and black for code style and integrated to GA#6679
CalvinKirs merged 8 commits intoapache:devfrom
zhongjiajie:py-code-style

Conversation

@zhongjiajie
Copy link
Copy Markdown
Member

@zhongjiajie zhongjiajie commented Nov 3, 2021 •
edited
Loading

  • Add describe and configure for code style
  • Add CI integrated to GitHub action, separator pydolphinscheduler directory in single CI process
  • Add some documentation about Github action and local run
  • Change pydolphinscheduler codebase for conform to code style check

@zhongjiajie zhongjiajie marked this pull request as ready for review November 3, 2021 08:58
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 3, 2021 •
edited
Loading

Codecov Report

Merging #6679 (e8a782a) into dev (1ebab35) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #6679      +/-   ##
============================================
- Coverage     37.80%   37.79%   -0.02%     
  Complexity     3225     3225              
============================================
  Files           649      649              
  Lines         26355    26355              
  Branches       2849     2849              
============================================
- Hits           9964     9961       -3     
- Misses        15479    15482       +3     
  Partials        912      912
Impacted Files Coverage Δ
...er/master/processor/queue/TaskResponseService.java 57.31% <0.00%> (-3.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ebab35...e8a782a. Read the comment docs.

@zhongjiajie zhongjiajie force-pushed the py-code-style branch 2 times, most recently from f3d92c6 to bd8945f Compare November 4, 2021 07:24
@zhongjiajie zhongjiajie changed the title [WIP][do-not-merge][python] Add python code style [python] Add flake8 and black for code style and integrated to GA Nov 5, 2021
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 5, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

davidzollo
davidzollo approved these changes Nov 5, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job
+1

CalvinKirs
CalvinKirs approved these changes Nov 5, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@CalvinKirs CalvinKirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job~

@CalvinKirs CalvinKirs merged commit 32d4411 into apache:dev Nov 5, 2021
@zhongjiajie zhongjiajie deleted the py-code-style branch November 5, 2021 07:23
@zhongjiajie
Copy link
Copy Markdown
Member Author

zhongjiajie commented Nov 5, 2021

Thanks

@zhongjiajie
Copy link
Copy Markdown
Member Author

zhongjiajie commented Nov 5, 2021

ref: #6407

@zhongjiajie zhongjiajie mentioned this pull request Nov 5, 2021
Closed
3 tasks
@zhongjiajie zhongjiajie mentioned this pull request Nov 17, 2021
Closed
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidzollo davidzollo davidzollo approved these changes

@CalvinKirs CalvinKirs CalvinKirs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhongjiajie @codecov-commenter @davidzollo @CalvinKirs