Skip to content

[python] Add param workgroup to process definition#6667

Merged
lenboo merged 1 commit intoapache:devfrom
zhongjiajie:workgroup-param
Nov 4, 2021
Merged

[python] Add param workgroup to process definition#6667
lenboo merged 1 commit intoapache:devfrom
zhongjiajie:workgroup-param

Conversation

@zhongjiajie
Copy link
Copy Markdown
Member

@zhongjiajie zhongjiajie commented Nov 2, 2021

Purpose of the pull request

This patch add work group to process definition. ref #6407

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 2, 2021

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.40%. Comparing base (2e70365) to head (380ce2b).
⚠️ Report is 3530 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6667      +/-   ##
============================================
- Coverage     38.41%   38.40%   -0.01%     
+ Complexity     3226     3225       -1     
============================================
  Files           646      646              
  Lines         25936    25936              
  Branches       2817     2817              
============================================
- Hits           9963     9962       -1     
  Misses        15058    15058              
- Partials        915      916       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zhongjiajie zhongjiajie changed the title [do-not-merge][python] Add param workgroup to process definition [do-not-merge][just-test][python] Add param workgroup to process definition Nov 3, 2021
@zhongjiajie zhongjiajie changed the title [do-not-merge][just-test][python] Add param workgroup to process definition [do-not-merge][just-test-for-now][python] Add param workgroup to process definition Nov 3, 2021
@zhongjiajie
Copy link
Copy Markdown
Member Author

Hi @caishunfeng maybe you could use this PR for template test

@caishunfeng
Copy link
Copy Markdown
Contributor

Hi @caishunfeng maybe you could use this PR for template test

Well done. Thanks ~

@zhongjiajie zhongjiajie changed the title [do-not-merge][just-test-for-now][python] Add param workgroup to process definition [python] Add param workgroup to process definition Nov 4, 2021
@zhongjiajie
Copy link
Copy Markdown
Member Author

I think is good to go now, PTAL @CalvinKirs @lenboo

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 4, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Copy Markdown
Member

@CalvinKirs CalvinKirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@lenboo lenboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lenboo lenboo merged commit 1165afb into apache:dev Nov 4, 2021
@zhongjiajie zhongjiajie deleted the workgroup-param branch November 5, 2021 01:35
@zhongjiajie
Copy link
Copy Markdown
Member Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants