Skip to content

[python] Add parameter schedule for process definition#6664

Merged
lenboo merged 8 commits intoapache:devfrom
zhongjiajie:add-schedule-workflow
Nov 13, 2021
Merged

[python] Add parameter schedule for process definition#6664
lenboo merged 8 commits intoapache:devfrom
zhongjiajie:add-schedule-workflow

Conversation

@zhongjiajie
Copy link
Copy Markdown
Member

@zhongjiajie zhongjiajie commented Nov 2, 2021 •
edited
Loading

In this patch I add schedule for process definition, is subtask of #6407 , closes: #6838

@zhongjiajie zhongjiajie mentioned this pull request Nov 2, 2021
Merged
@zhongjiajie zhongjiajie force-pushed the add-schedule-workflow branch from 3004b90 to 51c6d50 Compare November 4, 2021 04:18
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 4, 2021 •
edited
Loading

Codecov Report

Merging #6664 (32ef07b) into dev (0f92a1f) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #6664      +/-   ##
============================================
- Coverage     41.83%   41.79%   -0.05%     
+ Complexity     3615     3612       -3     
============================================
  Files           641      641              
  Lines         25890    25890              
  Branches       2795     2795              
============================================
- Hits          10832    10820      -12     
- Misses        14080    14093      +13     
+ Partials        978      977       -1
Impacted Files Coverage Δ
...r/plugin/registry/zookeeper/ZookeeperRegistry.java 47.27% <0.00%> (-7.28%) ⬇️
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...org/apache/dolphinscheduler/alert/AlertServer.java 55.00% <0.00%> (-5.00%) ⬇️
...er/server/master/runner/WorkflowExecuteThread.java 11.31% <0.00%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f92a1f...32ef07b. Read the comment docs.

lenboo
lenboo previously approved these changes Nov 4, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@lenboo lenboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zhongjiajie zhongjiajie force-pushed the add-schedule-workflow branch 2 times, most recently from cdbfa96 to cb34d4e Compare November 12, 2021 12:31
@zhongjiajie zhongjiajie changed the title [do-no-merge][python] Add parameter schedule for process definition [python] Add parameter schedule for process definition Nov 12, 2021
@zhongjiajie zhongjiajie force-pushed the add-schedule-workflow branch from e7211b2 to 499eca2 Compare November 13, 2021 08:50
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 13, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@zhongjiajie zhongjiajie requested a review from lenboo November 13, 2021 09:19
lenboo
lenboo approved these changes Nov 13, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@lenboo lenboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lenboo lenboo merged commit e76cf77 into apache:dev Nov 13, 2021
@zhongjiajie zhongjiajie deleted the add-schedule-workflow branch November 13, 2021 09:22
@zhongjiajie
Copy link
Copy Markdown
Member Author

zhongjiajie commented Nov 13, 2021

Thanks 🎉

@zhongjiajie zhongjiajie mentioned this pull request Nov 17, 2021
Closed
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lenboo lenboo lenboo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature][python] Add parameter schedule to process definition

3 participants

@zhongjiajie @codecov-commenter @lenboo