Skip to content

[1.3.6-prepare][Feature-5087][SqlTask] Add a switch to send mail and print head logs in SqlTask #5088#5104

Merged
xingchun-chen merged 2 commits intoapache:1.3.6-preparefrom
chengshiwen:1.3.6-prepare-feature-switch-to-send-email-in-sql-task
Mar 22, 2021
Merged

[1.3.6-prepare][Feature-5087][SqlTask] Add a switch to send mail and print head logs in SqlTask #5088#5104
xingchun-chen merged 2 commits intoapache:1.3.6-preparefrom
chengshiwen:1.3.6-prepare-feature-switch-to-send-email-in-sql-task

Conversation

@chengshiwen
Copy link
Copy Markdown
Member

@chengshiwen chengshiwen commented Mar 18, 2021

pr #5088
issue #174 #547 #5087

@chengshiwen chengshiwen requested a review from CalvinKirs March 19, 2021 10:12
@chengshiwen chengshiwen requested a review from CalvinKirs March 19, 2021 11:37
Copy link
Copy Markdown
Member

@CalvinKirs CalvinKirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM backend

@CalvinKirs
Copy link
Copy Markdown
Member

@zhuangchong @break60 please take a look UI.thx

@chengshiwen chengshiwen requested a review from CalvinKirs March 20, 2021 05:30
@zhuangchong
Copy link
Copy Markdown
Contributor

@chengshiwen @CalvinKirs

LIMIT limits the number of rows in a SQL query, and displayRows limits the number of rows that a log can print.
Isn't the number of queries the number of items to print?

@chengshiwen
Copy link
Copy Markdown
Member Author

chengshiwen commented Mar 20, 2021

@chengshiwen @CalvinKirs

LIMIT limits the number of rows in a SQL query, and displayRows limits the number of rows that a log can print.
Isn't the number of queries the number of items to print?

A user can choose not to send mail, so printing a few query results into the log is a good way. The variable displayRows is limited to less than 100, in order to avoid that the number of logs is too large.

For sending mail, the number of rows of query results sent can be larger, for example <= 10000

image

@chengshiwen chengshiwen force-pushed the 1.3.6-prepare-feature-switch-to-send-email-in-sql-task branch from ee34311 to 3ff9ee0 Compare March 20, 2021 06:24
@sonarqubecloud
Copy link
Copy Markdown

@zhuangchong
Copy link
Copy Markdown
Contributor

@chengshiwen @CalvinKirs

I wondered if this would make it more user-friendly,

SQL query result display has the email and log printing, on the front page for users to choose more the result display, set up the article a SQL query number limit parameters, the user can select only the log printing way, also can only choose mail way, also can also choose one of two ways (choice is at the same time may produce a large amount of data, this can agree)
In addition, I choose two display methods of log printing and email sending at the same time. I feel that the data can be viewed in either way many times at a time. Why should I view the data in both ways at the same time?


我想了一下这样调整会不会对用户更友好一些,
sql查询结果展示方式有邮件发送和日志打印,在前端页面可供用户进行多选结果展示方式,设置一个sql查询条数限制参数,用户可以只选择日志打印方式,也可以只选择邮件发送方式,也可以同时选择两种方式(同时选择的时候就是可能会产生很大的数据量,这个可以认同)

并且同时选择日志打印和邮件发送两种展示方法,我感觉多次一举,在任何一种方式都可以查看数据,为什么要两种方式同时查看?

@chengshiwen
Copy link
Copy Markdown
Member Author

@zhuangchong You can start a discussion in the dev email, and realize this improvement according to the idea you mentioned, not on this 1.3.6-prepare. The current pr is a cherry-pick from dev, and this improvement is the result of the previous discussion on March 17.

@zhuangchong
Copy link
Copy Markdown
Contributor

@zhuangchong You can start a discussion in the dev email, and realize this improvement according to the idea you mentioned, not on this 1.3.6-prepare. The current pr is a cherry-pick from dev, and this improvement is the result of the previous discussion on March 17.

ok, no problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants