Skip to content

[FIX-#4184][server-api] load TaskInstance slow #4186

Merged
davidzollo merged 1 commit intoapache:devfrom
wangxj3:dev
Dec 9, 2020
Merged

[FIX-#4184][server-api] load TaskInstance slow #4186
davidzollo merged 1 commit intoapache:devfrom
wangxj3:dev

Conversation

@wangxj3
Copy link
Copy Markdown
Contributor

@wangxj3 wangxj3 commented Dec 9, 2020

[FIX-#4184][server-api] load TaskInstanceslow
page of [TaskInstance] load data by interface "/dolphinscheduler/projects/stressTes/task-instance/list-paging" slow when the size of result more than 230000.
change "join" to " join left " in sql

optimize page of [TaskInstance] load data slow
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #4186 (96c7a8c) into dev (966600c) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #4186      +/-   ##
============================================
- Coverage     41.37%   41.34%   -0.04%     
+ Complexity     3115     3111       -4     
============================================
  Files           467      467              
  Lines         22168    22168              
  Branches       2720     2720              
============================================
- Hits           9172     9165       -7     
- Misses        12113    12117       +4     
- Partials        883      886       +3     
Impacted Files Coverage Δ Complexity Δ
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) 3.00% <0.00%> (-1.00%)
...e/dolphinscheduler/remote/NettyRemotingClient.java 50.00% <0.00%> (-2.78%) 9.00% <0.00%> (-2.00%)
...inscheduler/service/zk/CuratorZookeeperClient.java 60.97% <0.00%> (-2.44%) 7.00% <0.00%> (ø%)
...dolphinscheduler/remote/future/ResponseFuture.java 81.35% <0.00%> (-1.70%) 18.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 966600c...96c7a8c. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Dec 9, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Copy Markdown
Contributor

@lenboo lenboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@CalvinKirs CalvinKirs added the first time contributor First-time contributor label Dec 9, 2020
Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
good job

@davidzollo davidzollo added this to the 1.3.4-release milestone Dec 9, 2020
@davidzollo davidzollo linked an issue Dec 9, 2020 that may be closed by this pull request
@davidzollo davidzollo merged commit 9798123 into apache:dev Dec 9, 2020
@davidzollo
Copy link
Copy Markdown
Contributor

Thanks for your first contribution, looking forward to your deep participation

@lenboo lenboo removed this from the 1.3.4-release milestone Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

first time contributor First-time contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

page of [TaskInstance] load data slow

5 participants