[Feature][ui] Resume from force success#4160
Merged
davidzollo merged 4 commits intoapache:devfrom Jan 10, 2021
yinancx:dev
Merged
[Feature][ui] Resume from force success#4160davidzollo merged 4 commits intoapache:devfrom yinancx:dev
davidzollo merged 4 commits intoapache:devfrom
yinancx:dev
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #4160 +/- ##
============================================
+ Coverage 40.04% 41.36% +1.31%
- Complexity 2926 3113 +187
============================================
Files 459 467 +8
Lines 21793 22168 +375
Branches 2652 2720 +68
============================================
+ Hits 8727 9169 +442
+ Misses 12238 12115 -123
- Partials 828 884 +56
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
|
could you solve conflict files locally？ |
chengshiwen
reviewed
Dec 18, 2020
| _resumeFromForcedSuccess (item, index) { | ||
| this._countDownFn({ | ||
| id: item.id, | ||
| executeType: 'RESUME_FROM_FORCED_SUCCESS', |
Member
There was a problem hiding this comment.
There is no execution type called RESUME_FROM_FORCED_SUCCESS in dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/enums/ExecuteType.java, so it seems that submitting this execution type here will cause some problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
FORCED_SUCCESSSTART_FROM_FORCED_SUCCESSfor instance, for zh-cn, it calls从强制成功处继续Related issues
Brief change log
dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/instance/pages/list/_source/list.vueAdd a button and handlers for force success operation;dolphinscheduler-ui/src/js/module/i18n/locale/en_US.jsanddolphinscheduler-ui/src/js/module/i18n/locale/zh_CN.jsAdd related locale words.