Skip to content

[FIX-#4084][server]fix taskInstance state change error#4097

Merged
davidzollo merged 14 commits intoapache:devfrom
CalvinKirs:ack_status
Nov 26, 2020
Merged

[FIX-#4084][server]fix taskInstance state change error#4097
davidzollo merged 14 commits intoapache:devfrom
CalvinKirs:ack_status

Conversation

@CalvinKirs
Copy link
Copy Markdown
Member

@CalvinKirs CalvinKirs commented Nov 24, 2020

Concurrent processing of ack message and result message causes the execution sequence to be wrong

Optimize code and reduce database queries

this close #4084

Concurrent processing of ack message and result message causes the execution sequence to be wrong

# this close # 4083
@CalvinKirs CalvinKirs changed the title [FIX-#4083][server]fix taskInstance state change error [FIX-#4084][server]fix taskInstance state change error Nov 24, 2020
@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 24, 2020

Codecov Report

Merging #4097 (c902268) into dev (3c18139) will increase coverage by 0.20%.
The diff coverage is 21.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #4097      +/-   ##
============================================
+ Coverage     39.55%   39.75%   +0.20%     
- Complexity     2987     3008      +21     
============================================
  Files           467      467              
  Lines         22113    22136      +23     
  Branches       2714     2714              
============================================
+ Hits           8746     8801      +55     
+ Misses        12553    12526      -27     
+ Partials        814      809       -5     
Impacted Files Coverage Δ Complexity Δ
...ver/master/consumer/TaskPriorityQueueConsumer.java 5.92% <2.12%> (ø) 5.00 <1.00> (ø)
...lphinscheduler/service/process/ProcessService.java 4.91% <17.33%> (+0.01%) 6.00 <0.00> (ø)
...er/master/processor/queue/TaskResponseService.java 73.23% <63.33%> (+33.80%) 9.00 <0.00> (+4.00)
...he/dolphinscheduler/common/enums/SqoopJobType.java 0.00% <0.00%> (-88.89%) 0.00% <0.00%> (-3.00%)
...inscheduler/service/zk/CuratorZookeeperClient.java 56.09% <0.00%> (-9.76%) 6.00% <0.00%> (-2.00%)
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) 3.00% <0.00%> (-1.00%)
.../sqoop/generator/targets/MysqlTargetGenerator.java 71.42% <0.00%> (-4.33%) 5.00% <0.00%> (+1.00%) ⬇️
...nscheduler/server/worker/task/sqoop/SqoopTask.java 32.00% <0.00%> (-2.79%) 3.00% <0.00%> (ø%)
...k/sqoop/generator/targets/HiveTargetGenerator.java 56.25% <0.00%> (-1.82%) 3.00% <0.00%> (+1.00%) ⬇️
.../sqoop/generator/sources/MysqlSourceGenerator.java 57.69% <0.00%> (-0.31%) 6.00% <0.00%> (+1.00%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c18139...c902268. Read the comment docs.

@CalvinKirs CalvinKirs added this to the 1.3.4-release milestone Nov 24, 2020
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

38.5% 38.5% Coverage
0.0% 0.0% Duplication

Copy link
Copy Markdown
Contributor

@lenboo lenboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Copy Markdown
Contributor

@lgcareer lgcareer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@davidzollo davidzollo merged commit 656ec29 into apache:dev Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

taskInstance state change error

5 participants