Skip to content

[fix-#3843][api] When update workflow definition,if name already exists, the prompt is not friendly#3923

Merged
CalvinKirs merged 1 commit intoapache:devfrom
lgcareer:dev-fix
Oct 20, 2020
Merged

[fix-#3843][api] When update workflow definition,if name already exists, the prompt is not friendly#3923
CalvinKirs merged 1 commit intoapache:devfrom
lgcareer:dev-fix

Conversation

@lgcareer
Copy link
Copy Markdown
Contributor

What is the purpose of the pull request

[fix-3843][api] When update workflow definition,if name already exists, the prompt is not friendly

Brief change log

When update workflow definition,if name already exists, the prompt is not friendly

  • add verify whether process definition name exists in the update method

@lgcareer lgcareer changed the title [fix-3843][api] When update workflow definition,if name already exists, the prompt is not friendly [fix-#3843][api] When update workflow definition,if name already exists, the prompt is not friendly Oct 16, 2020
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3923 into dev will increase coverage by 0.12%.
The diff coverage is 28.57%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #3923      +/-   ##
============================================
+ Coverage     40.32%   40.45%   +0.12%     
- Complexity     2941     2953      +12     
============================================
  Files           460      460              
  Lines         21818    21822       +4     
  Branches       2650     2652       +2     
============================================
+ Hits           8799     8828      +29     
+ Misses        12184    12153      -31     
- Partials        835      841       +6     
Impacted Files Coverage Δ Complexity Δ
...api/service/impl/ProcessDefinitionServiceImpl.java 59.84% <16.66%> (-0.32%) 91.00 <0.00> (ø)
.../org/apache/dolphinscheduler/api/enums/Status.java 100.00% <100.00%> (ø) 5.00 <0.00> (ø)
...inscheduler/common/task/sqoop/SqoopParameters.java 74.00% <0.00%> (ø) 25.00% <0.00%> (ø%)
...inscheduler/service/zk/CuratorZookeeperClient.java 64.86% <0.00%> (+8.10%) 8.00% <0.00%> (+2.00%)
...rver/master/processor/queue/TaskResponseEvent.java 61.81% <0.00%> (+10.90%) 16.00% <0.00%> (+6.00%)
...er/master/processor/queue/TaskResponseService.java 55.76% <0.00%> (+23.07%) 6.00% <0.00%> (+1.00%)
...he/dolphinscheduler/common/enums/SqoopJobType.java 88.88% <0.00%> (+88.88%) 3.00% <0.00%> (+3.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62fb2fd...e53bd98. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

62.5% 62.5% Coverage
0.0% 0.0% Duplication

@zhuangchong
Copy link
Copy Markdown
Contributor

The dev branch supports checking the workflow name first and then saving the record.

@lgcareer lgcareer requested a review from lenboo October 16, 2020 08:16
@lgcareer
Copy link
Copy Markdown
Contributor Author

The dev branch supports checking the workflow name first and then saving the record.

OK,thanks,I added the verify process definition in backend in order to consistent with the branch 1.3.3-release.

Copy link
Copy Markdown

@DSExtension DSExtension left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Copy Markdown
Member

@CalvinKirs CalvinKirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@CalvinKirs CalvinKirs merged commit 4425968 into apache:dev Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants