Skip to content

[FIX-3573][DAO] potential horizontal unauthorized access#3880

Merged
lgcareer merged 2 commits intoapache:devfrom
lenboo:dev-mapper
Oct 12, 2020
Merged

[FIX-3573][DAO] potential horizontal unauthorized access#3880
lgcareer merged 2 commits intoapache:devfrom
lenboo:dev-mapper

Conversation

@lenboo
Copy link
Copy Markdown
Contributor

@lenboo lenboo commented Oct 10, 2020

fix bug(#3573) potential horizontal unauthorized access

@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 10, 2020

Codecov Report

Merging #3880 into dev will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #3880      +/-   ##
============================================
+ Coverage     40.29%   40.34%   +0.05%     
+ Complexity     2945     2940       -5     
============================================
  Files           460      460              
  Lines         21801    21801              
  Branches       2653     2650       -3     
============================================
+ Hits           8785     8796      +11     
+ Misses        12181    12166      -15     
- Partials        835      839       +4     
Impacted Files Coverage Δ Complexity Δ
...er/master/processor/queue/TaskResponseService.java 32.69% <0.00%> (-23.08%) 5.00% <0.00%> (-1.00%)
...rver/master/processor/queue/TaskResponseEvent.java 50.90% <0.00%> (-10.91%) 10.00% <0.00%> (-6.00%)
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) 3.00% <0.00%> (-1.00%)
...e/dolphinscheduler/remote/NettyRemotingClient.java 50.00% <0.00%> (-2.78%) 9.00% <0.00%> (-2.00%)
...dolphinscheduler/remote/future/ResponseFuture.java 79.66% <0.00%> (-1.70%) 17.00% <0.00%> (-1.00%)
...che/dolphinscheduler/server/zk/ZKMasterClient.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...lphinscheduler/service/process/ProcessService.java 4.80% <0.00%> (+4.80%) 6.00% <0.00%> (+6.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4be3b5...b9eba4e. Read the comment docs.

Copy link
Copy Markdown
Contributor Author

@lenboo lenboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for reminding!
"1=1" is not necessary.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Copy Markdown
Member

@CalvinKirs CalvinKirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Copy Markdown
Contributor

@lgcareer lgcareer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lgcareer lgcareer merged commit 9de7d3c into apache:dev Oct 12, 2020
@lenboo lenboo deleted the dev-mapper branch November 14, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants