[FIX_BUG_1.3#3789][remote]support netty heart beat#3868
[FIX_BUG_1.3#3789][remote]support netty heart beat#3868davidzollo merged 9 commits intoapache:devfrom CalvinKirs:netty_idle_heart
Conversation
|
can you mention the code in 1.3.3-release |
gabry-lab
left a comment
There was a problem hiding this comment.
It's better if we distinguish the READER_IDLE and WRITER_IDLE event
| @Override | ||
| public void userEventTriggered(ChannelHandlerContext ctx, Object evt) throws Exception { | ||
| if (evt instanceof IdleStateEvent) { | ||
| Command heartBeat = new Command(); |
There was a problem hiding this comment.
It's better if we distinguish the READER_IDLE and WRITER_IDLE event
There was a problem hiding this comment.
As far as heartbeat detection is concerned, this seems to be redundant. Regardless of the read and write events, they are all the same events. What do you think?
| @Override | ||
| public void userEventTriggered(ChannelHandlerContext ctx, Object evt) throws Exception { | ||
| // send heartbeat when read idle. | ||
| if (evt instanceof IdleStateEvent) { |
There was a problem hiding this comment.
It's better if we distinguish the READER_IDLE and WRITER_IDLE event
Codecov Report
@@ Coverage Diff @@
## dev #3868 +/- ##
============================================
+ Coverage 40.04% 40.35% +0.31%
- Complexity 2925 2944 +19
============================================
Files 459 460 +1
Lines 21793 21817 +24
Branches 2652 2650 -2
============================================
+ Hits 8726 8804 +78
+ Misses 12238 12177 -61
- Partials 829 836 +7
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed!
|
|
done |
no need to distinguish the read or write event
this closes #3789