Skip to content

[Fix-3840][server] Fix When the tenant code is a number, it should not be saved successfully#3867

Merged
qiaozhanwei merged 7 commits intoapache:devfrom
hermeshephaestus:origin/dev
Oct 8, 2020
Merged

[Fix-3840][server] Fix When the tenant code is a number, it should not be saved successfully#3867
qiaozhanwei merged 7 commits intoapache:devfrom
hermeshephaestus:origin/dev

Conversation

@hermeshephaestus
Copy link
Copy Markdown
Contributor

@hermeshephaestus hermeshephaestus commented Oct 1, 2020

header
[DS-ISSUE #3840][fix] fix ui

/**
* This is Regex expression utils.
*/
public class RegexUtils {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a private constructor to hide the implicit public one

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After changing this, there is no problem with this PR.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thank you for your suggestion, I have added a private constructor, please check that!

Copy link
Copy Markdown
Member

@CalvinKirs CalvinKirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hermeshephaestus
Copy link
Copy Markdown
Contributor Author

By the way, because the change of issue #3540 is really small, i have submitted the same pr together, please check the commits. @CalvinKirs @yangyichao-mango @yangxifi

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 3, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@CalvinKirs
Copy link
Copy Markdown
Member

By the way, because the change of issue #3540 is really small, i have submitted the same pr together, please check the commits. @CalvinKirs @yangyichao-mango @yangxifi

looks good to me,Let's wait for xingchun-chen review

Copy link
Copy Markdown
Contributor

@qiaozhanwei qiaozhanwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@qiaozhanwei qiaozhanwei merged commit 1c96ae0 into apache:dev Oct 8, 2020
@CalvinKirs
Copy link
Copy Markdown
Member

considering that it's your first contribution, I think we can get deep communiction, you can contact me through mail or add wechat(Kris_Evil), when mail or added, please tell me who you are, I think I can help to familiar with the DolphinScheduler if you meet with problems.

@xingchun-chen xingchun-chen modified the milestone: 1.3.3-release Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants