Skip to content

[Feature][ui]Waiting dependent nodes start timeout#3849

Merged
xingchun-chen merged 10 commits intoapache:devfrom
yinancx:dev
Sep 30, 2020
Merged

[Feature][ui]Waiting dependent nodes start timeout#3849
xingchun-chen merged 10 commits intoapache:devfrom
yinancx:dev

Conversation

@yinancx
Copy link
Copy Markdown
Contributor

@yinancx yinancx commented Sep 29, 2020

What is the purpose of the pull request

  • Modified dependent node info form, refine timeout settings.
  • For dependent nodes, now users can setting wait dependent start timeout and wait dependent complete timeout separately.
  • Users can set check interval for wait dependent start timeout.
  • Added input verification for new timeout settings.

Related issues

Brief change log

  • dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/_source/dependentTimeout.vue Create this file for dependent nodes' timeout setting;
  • dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/formModel.vue Add new timeout setting form and related parameters;
  • dolphinscheduler-ui/src/js/module/i18n/locale/en_US.js and dolphinscheduler-ui/src/js/module/i18n/locale/zh_CN.js Add locale words about new timeout settings;

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #3849 into dev will decrease coverage by 4.68%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #3849      +/-   ##
============================================
- Coverage     44.72%   40.03%   -4.69%     
- Complexity      138     2925    +2787     
============================================
  Files            41      459     +418     
  Lines          1033    21793   +20760     
  Branches         59     2652    +2593     
============================================
+ Hits            462     8725    +8263     
- Misses          530    12239   +11709     
- Partials         41      829     +788     
Impacted Files Coverage Δ Complexity Δ
...ler/remote/command/TaskExecuteResponseCommand.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
.../apache/dolphinscheduler/common/utils/OSUtils.java 44.57% <0.00%> (ø) 23.00% <0.00%> (?%)
...rver/master/dispatch/host/assign/HostSelector.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...phinscheduler/common/plugin/PluginClassLoader.java 28.84% <0.00%> (ø) 6.00% <0.00%> (?%)
...rg/apache/dolphinscheduler/api/dto/gantt/Task.java 62.96% <0.00%> (ø) 9.00% <0.00%> (?%)
...olphinscheduler/dao/entity/ProcessInstanceMap.java 41.93% <0.00%> (ø) 9.00% <0.00%> (?%)
.../master/dispatch/host/assign/AbstractSelector.java 66.66% <0.00%> (ø) 3.00% <0.00%> (?%)
...phinscheduler/server/master/future/TaskFuture.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...he/dolphinscheduler/common/utils/ScriptRunner.java 58.57% <0.00%> (ø) 15.00% <0.00%> (?%)
...che/dolphinscheduler/common/utils/LoggerUtils.java 62.50% <0.00%> (ø) 5.00% <0.00%> (?%)
... and 409 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db663a1...61fcad7. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Copy Markdown
Contributor

@break60 break60 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
good job!

Copy link
Copy Markdown
Contributor

@xingchun-chen xingchun-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@xingchun-chen xingchun-chen merged commit 76f6e20 into apache:dev Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants