Skip to content

[Fix][API] Log dependency package conflict#3833

Merged
davidzollo merged 1 commit intoapache:devfrom
hailin0:log-dependency-conflict
Oct 10, 2020
Merged

[Fix][API] Log dependency package conflict#3833
davidzollo merged 1 commit intoapache:devfrom
hailin0:log-dependency-conflict

Conversation

@hailin0
Copy link
Copy Markdown
Member

@hailin0 hailin0 commented Sep 27, 2020

Tips

What is the purpose of the pull request

Fix log dependency package conflict (slf4j-log4j12、logback)

Brief change log

Add exclusion for slf4j-log4j12

Verify this pull request

This pull request is code cleanup without any test coverage.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@hailin0
Copy link
Copy Markdown
Member Author

hailin0 commented Sep 28, 2020

@qiaozhanwei

Copy link
Copy Markdown
Member

@CalvinKirs CalvinKirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@hailin0
Copy link
Copy Markdown
Member Author

hailin0 commented Oct 10, 2020

@dailidong Waiting for request to merged

Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
good job

@davidzollo davidzollo merged commit c4be3b5 into apache:dev Oct 10, 2020
@davidzollo
Copy link
Copy Markdown
Contributor

thanks for your first contribution, looking forward for your deep participation, please contact me(wechat: 510570367 or mail: dailidong66@gmail.com), when added, please tell me your github id, thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants