Skip to content

[Improvement][server]lower weight round robin support weight#3768

Merged
EricJoy2048 merged 4 commits intoapache:devfrom
CalvinKirs:loadbalance_weight_lower_weight
Sep 28, 2020
Merged

[Improvement][server]lower weight round robin support weight#3768
EricJoy2048 merged 4 commits intoapache:devfrom
CalvinKirs:loadbalance_weight_lower_weight

Conversation

@CalvinKirs
Copy link
Copy Markdown
Member

What is the purpose of the pull request

lower weight round robin support weight

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

Copy link
Copy Markdown
Member

@EricJoy2048 EricJoy2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Copy Markdown
Contributor

@qiaozhanwei qiaozhanwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@qiaozhanwei
Copy link
Copy Markdown
Contributor

please resolve conflicts . Thx

@CalvinKirs
Copy link
Copy Markdown
Member Author

please resolve conflicts . Thx

Thank you very much for your review, I will finish it later

# Conflicts:
#	dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/dispatch/host/assign/HostWeight.java
#	dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/master/dispatch/host/assign/LowerWeightRoundRobinTest.java
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Copy Markdown
Member

@EricJoy2048 EricJoy2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@EricJoy2048 EricJoy2048 merged commit 11d3c2c into apache:dev Sep 28, 2020
@CalvinKirs CalvinKirs deleted the loadbalance_weight_lower_weight branch October 20, 2020 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants