[Improvement][API] simplify with stream#3764
Merged
davidzollo merged 4 commits intoapache:devfrom Sep 26, 2020
Merged
Conversation
Technoboy-
reviewed
Sep 18, 2020
...src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
Show resolved
Hide resolved
Contributor
|
good job， could you add unit test for this method? |
Contributor
Author
completely fine, i will finish this before this weekend |
b3ef621 to
0939375
Compare
0939375 to
b896827
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
davidzollo
approved these changes
Sep 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
simplify for loop with stream