Skip to content

[Fix-3750][tools] check-LICENSE.sh: support sub dirs in dist/lib#3752

Merged
lgcareer merged 1 commit intoapache:devfrom
hsupu:dev-3750
Sep 21, 2020
Merged

[Fix-3750][tools] check-LICENSE.sh: support sub dirs in dist/lib#3752
lgcareer merged 1 commit intoapache:devfrom
hsupu:dev-3750

Conversation

@hsupu
Copy link
Copy Markdown
Contributor

@hsupu hsupu commented Sep 15, 2020

What is the purpose of the pull request

Brief change log

  • use find + sed instead of ls to fix the problem.

Verify this pull request

This change added tests and can be verified as follows:

  • No test case cover it, so you should run the script manually.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Copy Markdown
Member

@EricJoy2048 EricJoy2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Copy Markdown
Contributor

@lgcareer lgcareer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lgcareer lgcareer merged commit 8ef0431 into apache:dev Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants