[FIXBUG][common]fix yarn applications status cause NPE(#3645) by 597365581 · Pull Request #3648 · apache/dolphinscheduler

597365581 · 2020-09-02T09:34:41Z

[FIXBUG][common]fix yarn applications status cause NPE

Tips

Thanks very much for contributing to Apache DolphinScheduler.
Please review https://dolphinscheduler.apache.org/en-us/community/index.html before opening a pull request.

What is the purpose of the pull request

(For example: This pull request adds checkstyle plugin.)

Brief change log

(for example:)

Add maven-checkstyle-plugin to root pom.xml

Verify this pull request

(Please pick either of the following options)

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

Added dolphinscheduler-dao tests for end-to-end.
Added CronUtilsTest to verify the change.
Manually verified the change by testing locally.

fix get yarn applications status from yarn server,http code return 404, get yarn applications status cause NullPointerException

sonarqubecloud · 2020-09-02T09:49:40Z

Please retry analysis of this Pull-Request directly on SonarCloud.

597365581

fix get yarn applications status from yarn server,http code return 404, get yarn applications status cause NullPointerException

597365581

get yarn applications status from yarn server,http code return 404, get yarn applications status cause NullPointerException

597365581 · 2020-09-02T11:15:20Z

fix get yarn applications status from yarn server,http code return 404, get yarn applications status cause NullPointerException

felix-thinkingdata · 2020-09-02T11:29:07Z

Can you describe what happens when volatilization happens? There is a difference between getting a status return exception, such as 404, and a task running status failure.

什么情况下会发生？还有就是获取状态404和获取运行状态是失败的还是有区别的。

felix-thinkingdata · 2020-09-02T11:37:30Z

Can you describe what happens when volatilization happens? There is a difference between getting a status return exception, such as 404, and a task running status failure.It's best to describe the situation in detail.

什么情况下会发生？还有就是获取状态404和获取运行状态是失败的还是有区别的。最好详细描述下情况。

597365581 · 2020-09-02T11:46:54Z

Can you describe what happens when volatilization happens? There is a difference between getting a status return exception, such as 404, and a task running status failure.It's best to describe the situation in detail.

什么情况下会发生？还有就是获取状态404和获取运行状态是失败的还是有区别的。最好详细描述下情况。

1、yarn http request timeout。2、yarn url is incorrect and so no...

597365581 · 2020-09-02T11:51:17Z

Can you describe what happens when volatilization happens? There is a difference between getting a status return exception, such as 404, and a task running status failure.It's best to describe the situation in detail.

什么情况下会发生？还有就是获取状态404和获取运行状态是失败的还是有区别的。最好详细描述下情况。

1、yarn http request timeout。2、yarn url is incorrect 3、 two yarn cluster，yarn url config in disorder and so no...

felix-thinkingdata · 2020-09-03T03:20:17Z

Can you describe what happens when volatilization happens? There is a difference between getting a status return exception, such as 404, and a task running status failure.It's best to describe the situation in detail.

什么情况下会发生？还有就是获取状态404和获取运行状态是失败的还是有区别的。最好详细描述下情况。

1、yarn http request timeout。2、yarn url is incorrect 3、 two yarn cluster，yarn url config in disorder and so no...

Does this erase any specific exception information in the log?

这样会抹去在日志中的具体的异常信息吗？

felix-thinkingdata · 2020-09-03T03:23:03Z

Can you describe what happens when volatilization happens? There is a difference between getting a status return exception, such as 404, and a task running status failure.It's best to describe the situation in detail.

什么情况下会发生？还有就是获取状态404和获取运行状态是失败的还是有区别的。最好详细描述下情况。

1、yarn http request timeout。2、yarn url is incorrect 3、 two yarn cluster，yarn url config in disorder and so no...

Does this erase any specific exception information in the log?

这样会抹去在日志中的具体的异常信息吗？
I see that the lower utility class prints a detailed exception.
我看到了，下层工具类会打印详细异常。

felix-thinkingdata

Optimized exceptions when getting information over YARN HTTP.

优化了，在通过yarn http获取信息时的异常情况。

good job

597365581 · 2020-09-03T03:32:59Z

Optimized exceptions when getting information over YARN HTTP.

优化了，在通过yarn http获取信息时的异常情况。

good job

ok，can merge？

felix-thinkingdata · 2020-09-03T05:59:30Z

ok，can merge？

Wait for others to review.I have no authority to merge

CalvinKirs

+1
but，multiple if nesting does not seem intuitive enough, if it can be modified, it would be better。

CalvinKirs · 2020-09-03T06:16:29Z

please change the pr title to [FIXBUG][common]fix yarn applications status cause NPE

yangyichao-mango

LGTM

felix-thinkingdata · 2020-09-04T03:39:12Z

please change the pr title to [FIXBUG][common]fix yarn applications status cause NPE

按照要求改下标题。

597365581 · 2020-09-04T04:43:56Z

@felix-thinkingdata ok, title has changed

qiaozhanwei

+1

597365581 added 3 commits September 2, 2020 17:30

fix apache#3645

4c0fe59

fix get yarn applications status from yarn server,http code return 404, get yarn applications status cause NullPointerException

Update HadoopUtils.java

81bc185

Update HadoopUtils.java

d3a4ad8

597365581 commented Sep 2, 2020

View reviewed changes

597365581 marked this pull request as draft September 2, 2020 09:57

597365581 marked this pull request as ready for review September 2, 2020 11:00

597365581 marked this pull request as draft September 2, 2020 11:14

597365581 marked this pull request as ready for review September 2, 2020 11:15

felix-thinkingdata approved these changes Sep 3, 2020

View reviewed changes

597365581 marked this pull request as draft September 3, 2020 03:35

597365581 marked this pull request as ready for review September 3, 2020 03:36

CalvinKirs reviewed Sep 3, 2020

View reviewed changes

yangyichao-mango approved these changes Sep 3, 2020

View reviewed changes

597365581 changed the title ~~fix #3645~~ [FIXBUG][common]fix yarn applications status cause NPE Sep 4, 2020

597365581 changed the title ~~[FIXBUG][common]fix yarn applications status cause NPE~~ [FIXBUG][common]fix yarn applications status cause NPE(#3645) Sep 4, 2020

qiaozhanwei approved these changes Sep 7, 2020

View reviewed changes

qiaozhanwei merged commit ba3adbd into apache:dev Sep 7, 2020

Conversation

597365581 commented Sep 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Tips

What is the purpose of the pull request

Brief change log

Verify this pull request

Uh oh!

sonarqubecloud bot commented Sep 2, 2020

Uh oh!

597365581 left a comment

Choose a reason for hiding this comment

Uh oh!

597365581 left a comment

Choose a reason for hiding this comment

Uh oh!

597365581 commented Sep 2, 2020

Uh oh!

felix-thinkingdata commented Sep 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

felix-thinkingdata commented Sep 2, 2020

Uh oh!

597365581 commented Sep 2, 2020

Uh oh!

597365581 commented Sep 2, 2020

Uh oh!

felix-thinkingdata commented Sep 3, 2020

Uh oh!

felix-thinkingdata commented Sep 3, 2020

Uh oh!

felix-thinkingdata left a comment

Choose a reason for hiding this comment

Uh oh!

597365581 commented Sep 3, 2020

Uh oh!

felix-thinkingdata commented Sep 3, 2020

Uh oh!

CalvinKirs left a comment

Choose a reason for hiding this comment

Uh oh!

CalvinKirs commented Sep 3, 2020

Uh oh!

yangyichao-mango left a comment

Choose a reason for hiding this comment

Uh oh!

felix-thinkingdata commented Sep 4, 2020

Uh oh!

597365581 commented Sep 4, 2020

Uh oh!

qiaozhanwei left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

597365581 commented Sep 2, 2020 •

edited

Loading

felix-thinkingdata commented Sep 2, 2020 •

edited

Loading