[Improvement][ALL] Remove some un-used code and code review #3639#3640
Merged
qiaozhanwei merged 8 commits intoapache:devfrom Sep 3, 2020
Merged
[Improvement][ALL] Remove some un-used code and code review #3639#3640qiaozhanwei merged 8 commits intoapache:devfrom
qiaozhanwei merged 8 commits intoapache:devfrom
Conversation
# Conflicts: # dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/dto/resources/filter/ResourceFilterTest.java
Codecov Report
@@ Coverage Diff @@
## dev #3640 +/- ##
============================================
- Coverage 39.25% 39.17% -0.08%
+ Complexity 2836 2830 -6
============================================
Files 456 456
Lines 21608 21597 -11
Branches 2623 2622 -1
============================================
- Hits 8482 8461 -21
- Misses 12337 12346 +9
- Partials 789 790 +1
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed!
|
CalvinKirs
approved these changes
Sep 2, 2020
Member
CalvinKirs
left a comment
There was a problem hiding this comment.
LGTM.
Thanks for your contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
#3639
Brief change
Remove some un-used code
Verify this pull request
UnNeed
This pull request is code cleanup without any test coverage.