[Improvement][server] Refactor code for getTaskLogPath to reduce NPE log during UT#3629
Merged
qiaozhanwei merged 9 commits intoapache:devfrom Sep 7, 2020
Merged
[Improvement][server] Refactor code for getTaskLogPath to reduce NPE log during UT#3629qiaozhanwei merged 9 commits intoapache:devfrom
qiaozhanwei merged 9 commits intoapache:devfrom
Conversation
Member
|
There is a code smell, can you try to solve it? |
Codecov Report
@@ Coverage Diff @@
## dev #3629 +/- ##
============================================
- Coverage 39.25% 39.22% -0.04%
Complexity 2835 2835
============================================
Files 456 457 +1
Lines 21608 21612 +4
Branches 2623 2621 -2
============================================
- Hits 8483 8477 -6
- Misses 12336 12350 +14
+ Partials 789 785 -4 Continue to review full report at Codecov.
|
yangyichao-mango
requested changes
Sep 4, 2020
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/utils/LogUtils.java
Outdated
Show resolved
Hide resolved
...hinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/utils/LogUtilsTest.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
Brief change log
org.apache.dolphinscheduler.server.utils.LogUtilsMasterBaseTaskExecThread.getTaskLogPathorg.apache.dolphinscheduler.server.worker.processor.TaskExecuteProcessor.getTaskLogPathVerify this pull request
This change added tests and can be verified as follows:
org.apache.dolphinscheduler.server.utils.LogUtilsTest.