Skip to content

[Improvement-3612][ui] Workflow version control ui optimize#3622

Merged
qiaozhanwei merged 4 commits intoapache:devfrom
yangyichao-mango:improvement-workflow-ui
Sep 7, 2020
Merged

[Improvement-3612][ui] Workflow version control ui optimize#3622
qiaozhanwei merged 4 commits intoapache:devfrom
yangyichao-mango:improvement-workflow-ui

Conversation

@yangyichao-mango
Copy link
Copy Markdown
Contributor

@yangyichao-mango yangyichao-mango commented Aug 28, 2020 •
edited
Loading

What is the purpose of the pull request

Workflow version control ui optimize (#3612 )

Brief change log

@yangyichao-mango yangyichao-mango changed the title [Improvement][ui] Workflow version control ui optimize [Improvement-3612][ui] Workflow version control ui optimize Aug 28, 2020
@break60
Copy link
Copy Markdown
Contributor

break60 commented Aug 28, 2020 •
edited by xingchun-chen
Loading

Why not delete the entire column
image

@yangyichao-mango
Copy link
Copy Markdown
Contributor Author

yangyichao-mango commented Aug 28, 2020 •
edited
Loading

@break60

  1. I do not remove this span is for the beauty of ui and I'am not familiar with css. Any suggestion about this?
    Before remove span:
    image
    After remove span:
    image

  2. And I try to use tooltips, but it still have some problem, your can refer to [Improvement][ui] UI optimization for workflow version   #3612 conversation about list page description, please help to give some suggestions, Thx a lot~

@xingchun-chen
Copy link
Copy Markdown
Contributor

xingchun-chen commented Aug 31, 2020

@yangyichao-mango
image

@yangyichao-mango
Copy link
Copy Markdown
Contributor Author

yangyichao-mango commented Aug 31, 2020

@yangyichao-mango
image

Got.

@yangyichao-mango
Copy link
Copy Markdown
Contributor Author

yangyichao-mango commented Aug 31, 2020

@chenxingchun done. Please help to review.

@break60
Copy link
Copy Markdown
Contributor

break60 commented Sep 1, 2020

"span"Can be deleted

@yangyichao-mango
Copy link
Copy Markdown
Contributor Author

yangyichao-mango commented Sep 1, 2020

"span"Can be deleted

But if span is deleted, it will make the ui of version list ugly, so I just put it for place holder and it will make the list more pretty. I think we can keep it now, if there is need to replace span with css later, it will be better.

@break60
Copy link
Copy Markdown
Contributor

break60 commented Sep 2, 2020

"span"Can be deleted

But if span is deleted, it will make the ui of version list ugly, so I just put it for place holder and it will make the list more pretty. I think we can keep it now, if there is need to replace span with css later, it will be better.

Delete span, change the first th to Version

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Sep 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yangyichao-mango
Copy link
Copy Markdown
Contributor Author

yangyichao-mango commented Sep 2, 2020

@break60 done. Please help to review.

@qiaozhanwei
Copy link
Copy Markdown
Contributor

qiaozhanwei commented Sep 7, 2020

@break60

break60
break60 approved these changes Sep 7, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@break60 break60 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

qiaozhanwei
qiaozhanwei approved these changes Sep 7, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@qiaozhanwei qiaozhanwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@qiaozhanwei qiaozhanwei merged commit c7a2f92 into apache:dev Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qiaozhanwei qiaozhanwei qiaozhanwei approved these changes

+1 more reviewer

@break60 break60 break60 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yangyichao-mango @break60 @xingchun-chen @qiaozhanwei