Skip to content

[FIX][UI]add button disabeld when isDetails#3611

Merged
qiaozhanwei merged 1 commit intoapache:devfrom
geosmart:patch-1
Aug 31, 2020
Merged

[FIX][UI]add button disabeld when isDetails#3611
qiaozhanwei merged 1 commit intoapache:devfrom
geosmart:patch-1

Conversation

@geosmart
Copy link
Copy Markdown
Contributor

with ONLINE process definition Add button should disabeld for readOnly

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@break60
Copy link
Copy Markdown
Contributor

break60 commented Aug 27, 2020

Is the save button in the gray toolbar more friendly
image

@geosmart
Copy link
Copy Markdown
Contributor Author

Is the save button in the gray toolbar more friendly

after click save ,user have to config something before click add
image

@break60
Copy link
Copy Markdown
Contributor

break60 commented Aug 27, 2020

You add this graying out for the work that is already online. The backend of the online workflow is checked. If you are only for the online workflow, you can prevent the user from clicking the save button and restrict the user from adding it. Can’t add some changes

@geosmart
Copy link
Copy Markdown
Contributor Author

You add this graying out for the work that is already online. The backend of the online workflow is checked. If you are only for the online workflow, you can prevent the user from clicking the save button and restrict the user from adding it. Can’t add some changes

but if disabled the save button , i can't check the config[tenant,alert,timeout]info in the popout dialog,
so I just graying out the add button to avoid unnecessary click

@break60
Copy link
Copy Markdown
Contributor

break60 commented Aug 27, 2020

but if disabled the save button , i can't check the config[tenant,alert,timeout]info in the popout dialog,
so I just graying out the add button to avoid unnecessary click

If the user needs to see the configuration information inside, it is also possible

Copy link
Copy Markdown
Contributor

@break60 break60 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Copy Markdown
Contributor

@qiaozhanwei qiaozhanwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@qiaozhanwei qiaozhanwei merged commit fbeadfd into apache:dev Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants