Skip to content

[refactor][server-test] refactor RoundRobinHostManagerTest#3511

Merged
davidzollo merged 6 commits intoapache:devfrom
CalvinKirs:thread_test
Aug 31, 2020
Merged

[refactor][server-test] refactor RoundRobinHostManagerTest#3511
davidzollo merged 6 commits intoapache:devfrom
CalvinKirs:thread_test

Conversation

@CalvinKirs
Copy link
Copy Markdown
Member

@CalvinKirs CalvinKirs commented Aug 15, 2020 •
edited
Loading

refactor RoundRobinHostManagerTest

#3512

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 19, 2020

Codecov Report

Merging #3511 into dev will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #3511      +/-   ##
============================================
+ Coverage     36.35%   36.39%   +0.03%     
- Complexity     2639     2640       +1     
============================================
  Files           449      449              
  Lines         21255    21255              
  Branches       2602     2602              
============================================
+ Hits           7727     7735       +8     
+ Misses        12813    12801      -12     
- Partials        715      719       +4
Impacted Files Coverage Δ Complexity Δ
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) 3.00% <0.00%> (-1.00%)
...inscheduler/service/zk/CuratorZookeeperClient.java 62.16% <0.00%> (-2.71%) 7.00% <0.00%> (-1.00%)
...inscheduler/common/task/sqoop/SqoopParameters.java 74.00% <0.00%> (ø) 25.00% <0.00%> (ø%)
...he/dolphinscheduler/common/thread/ThreadUtils.java 72.30% <0.00%> (+3.07%) 14.00% <0.00%> (ø%)
...he/dolphinscheduler/common/enums/SqoopJobType.java 88.88% <0.00%> (+88.88%) 3.00% <0.00%> (+3.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4ee351...f443d6e. Read the comment docs.

@CalvinKirs
Copy link
Copy Markdown
Member Author

CalvinKirs commented Aug 20, 2020

@dailidong @qiaozhanwei Could you please review this for me?

yangyichao-mango
yangyichao-mango approved these changes Aug 22, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@yangyichao-mango yangyichao-mango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

qiaozhanwei
qiaozhanwei approved these changes Aug 25, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@qiaozhanwei qiaozhanwei left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please resolved conflicts
+1

@CalvinKirs
Merge branch 'dev' into thread_test
e45eb3a 
# Conflicts:
#	pom.xml
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Aug 25, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@CalvinKirs
Copy link
Copy Markdown
Member Author

CalvinKirs commented Aug 25, 2020

please resolved conflicts
+1

I have completed the changes, please check

@davidzollo davidzollo linked an issue Aug 31, 2020 that may be closed by this pull request
[refactor][Test*] refactor test #3512
Closed
davidzollo
davidzollo approved these changes Aug 31, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
great job for DS

@davidzollo davidzollo modified the milestones: 1.4.0, 1.3.3-release Aug 31, 2020
@davidzollo davidzollo merged commit 632d52c into apache:dev Aug 31, 2020
@xingchun-chen xingchun-chen modified the milestones: 1.3.3-release, 1.4.0 Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidzollo davidzollo davidzollo approved these changes

@qiaozhanwei qiaozhanwei qiaozhanwei approved these changes

@yangyichao-mango yangyichao-mango yangyichao-mango approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.4.0

Development

Successfully merging this pull request may close these issues.

[refactor][Test*] refactor test

6 participants

@CalvinKirs @codecov-commenter @davidzollo @qiaozhanwei @yangyichao-mango @xingchun-chen