Skip to content

[Test][api] Introduce api controller unit test example#3447

Merged
qiaozhanwei merged 2 commits intoapache:devfrom
yangyichao-mango:test-controller-example
Aug 10, 2020
Merged

[Test][api] Introduce api controller unit test example#3447
qiaozhanwei merged 2 commits intoapache:devfrom
yangyichao-mango:test-controller-example

Conversation

@yangyichao-mango
Copy link
Copy Markdown
Contributor

What is the purpose of the pull request

Introduce api controller unit test example

Brief change log

  • Improve ProcessInstanceControllerTest
  • Format code style

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #3447 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                dev    #3447   +/-   ##
=========================================
  Coverage     35.97%   35.97%           
- Complexity     2599     2600    +1     
=========================================
  Files           448      448           
  Lines         20878    20878           
  Branches       2558     2558           
=========================================
  Hits           7511     7511           
  Misses        12681    12681           
  Partials        686      686           
Impacted Files Coverage Δ Complexity Δ
...he/dolphinscheduler/common/thread/ThreadUtils.java 69.23% <0.00%> (-3.08%) 14.00% <0.00%> (ø%)
...he/dolphinscheduler/api/service/LoggerService.java 82.35% <0.00%> (+5.88%) 10.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40a2181...3b17e30. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Aug 9, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Copy Markdown
Member

@CalvinKirs CalvinKirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Copy Markdown
Contributor

@qiaozhanwei qiaozhanwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@qiaozhanwei qiaozhanwei merged commit 4fb06a7 into apache:dev Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants