Skip to content

[Improvement-3369][api] Introduce data analysis service interface for clear code#3439

Merged
qiaozhanwei merged 3 commits intoapache:devfrom
yangyichao-mango:feature-dataanalysisservice
Aug 10, 2020
Merged

[Improvement-3369][api] Introduce data analysis service interface for clear code#3439
qiaozhanwei merged 3 commits intoapache:devfrom
yangyichao-mango:feature-dataanalysisservice

Conversation

@yangyichao-mango
Copy link
Copy Markdown
Contributor

What is the purpose of the pull request

Introduce data analysis service interface for clear code

Brief change log

  • Change DataAnalysisService class to interface
  • Add DataAnalysisServiceImpl class for DataAnalysisService interface
  • Format the code style

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Aug 8, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 6 Code Smells

54.0% 54.0% Coverage
0.0% 0.0% Duplication

@yangyichao-mango yangyichao-mango changed the title [Improvement][api] Introduce data analysis service interface for clear code [Improvement-3369][api] Introduce data analysis service interface for clear code Aug 8, 2020
Copy link
Copy Markdown
Contributor

@qiaozhanwei qiaozhanwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@qiaozhanwei qiaozhanwei merged commit 3ed0afa into apache:dev Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants