Skip to content

[Improvement-3369][api] Introduce logger service interface for clear code#3437

Merged
qiaozhanwei merged 2 commits intoapache:devfrom
yangyichao-mango:feature-loggerservice
Aug 10, 2020
Merged

[Improvement-3369][api] Introduce logger service interface for clear code#3437
qiaozhanwei merged 2 commits intoapache:devfrom
yangyichao-mango:feature-loggerservice

Conversation

@yangyichao-mango
Copy link
Copy Markdown
Contributor

What is the purpose of the pull request

Introduce logger service interface for clear code

Brief change log

  • Change LoggerService class to interface
  • Add isRunning for LogClientService

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Aug 8, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

78.9% 78.9% Coverage
0.0% 0.0% Duplication

@yangyichao-mango yangyichao-mango changed the title [Improvement][api] Introduce logger service interface for clear code [Improvement-3369][api] Introduce logger service interface for clear code Aug 8, 2020
Copy link
Copy Markdown
Contributor

@qiaozhanwei qiaozhanwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@qiaozhanwei qiaozhanwei merged commit dce403d into apache:dev Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants