Skip to content

[Improvement-3369][api] Introduce session service interface for clear code#3408

Merged
qiaozhanwei merged 4 commits intoapache:devfrom
yangyichao-mango:feature-sessionservice
Aug 10, 2020
Merged

[Improvement-3369][api] Introduce session service interface for clear code#3408
qiaozhanwei merged 4 commits intoapache:devfrom
yangyichao-mango:feature-sessionservice

Conversation

@yangyichao-mango
Copy link
Copy Markdown
Contributor

What is the purpose of the pull request

Introduce session service interface for clear code

Brief change log

  • Format BaseService code style
  • Introduce SessionServiceImpl
  • Change SessionService class to SessionService interface

Verify this pull request

This pull request is already covered by existing tests.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Aug 5, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

76.9% 76.9% Coverage
0.0% 0.0% Duplication

@yangyichao-mango yangyichao-mango changed the title [Improvement][api] Introduce session service interface for clear code [Improvement-3369][api] Introduce session service interface for clear code Aug 8, 2020
Copy link
Copy Markdown
Contributor

@qiaozhanwei qiaozhanwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@qiaozhanwei qiaozhanwei merged commit 379203b into apache:dev Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants