Skip to content

[Feature-3392][api-server]#3403

Merged
davidzollo merged 8 commits intoapache:devfrom
cpsky:dev
Aug 5, 2020
Merged

[Feature-3392][api-server]#3403
davidzollo merged 8 commits intoapache:devfrom
cpsky:dev

Conversation

@cpsky
Copy link
Copy Markdown
Contributor

@cpsky cpsky commented Aug 4, 2020

What is the purpose of the pull request

add admin activate user api
#3392

Brief change log

  • Add function to userController and userService
  • Add unit test about new feature
  • change some detail abount user-self register on userService
  • change some return filed about user-self register api and activate user api

Verify this pull request

This pull request is already covered by existing tests, such as (please describe tests).

  • Added CronUtilsTest to verify the change.
  • Manually verified the change by testing locally.

Copy link
Copy Markdown
Contributor

@yangyichao-mango yangyichao-mango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@davidzollo davidzollo linked an issue Aug 5, 2020 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
good job

@davidzollo davidzollo added the enhancement New feature or request label Aug 5, 2020
@davidzollo davidzollo merged commit 6dc5009 into apache:dev Aug 5, 2020
@davidzollo davidzollo added this to the 1.4.0 milestone Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][Api] Admin can activate user registerd by themselves

3 participants