Skip to content

[Improvement-3369][api] Introduce api service interface for ProcessDefinitionService#3371

Merged
qiaozhanwei merged 2 commits intoapache:devfrom
yangyichao-mango:feature-3369
Aug 10, 2020
Merged

[Improvement-3369][api] Introduce api service interface for ProcessDefinitionService#3371
qiaozhanwei merged 2 commits intoapache:devfrom
yangyichao-mango:feature-3369

Conversation

@yangyichao-mango
Copy link
Copy Markdown
Contributor

@yangyichao-mango yangyichao-mango commented Aug 1, 2020

What is the purpose of the pull request

Code clean and improvement, make the api module service more cleaner, change ProcessDefinitionService for example

Brief change log

  • Add ProcessDefinitionService interface and move the ProcessDefinitionService impl to ProcessDefinitionServiceImpl

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Aug 1, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 11 Code Smells

49.9% 49.9% Coverage
0.0% 0.0% Duplication

@yangyichao-mango yangyichao-mango changed the title [Improvement-3369][api] Code clean and improvement [Improvement-3369][api] Introduce api service interface for ProcessDefinitionService Aug 1, 2020
Copy link
Copy Markdown
Contributor

@qiaozhanwei qiaozhanwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@qiaozhanwei qiaozhanwei merged commit 133b4de into apache:dev Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants