Skip to content

[Fix-3338][ui] Fix the warning when user do not fill the node blank#3349

Merged
davidzollo merged 2 commits intoapache:devfrom
yangyichao-mango:feature-3338
Jul 30, 2020
Merged

[Fix-3338][ui] Fix the warning when user do not fill the node blank#3349
davidzollo merged 2 commits intoapache:devfrom
yangyichao-mango:feature-3338

Conversation

@yangyichao-mango
Copy link
Copy Markdown
Contributor

What is the purpose of the pull request

close(#3338 )
Fix the warning when user do not fill the node blank

Brief change log

  • Format the Please enter name(required) to Please enter name (required)

Verify this pull request

  • Manually verified the change by testing locally.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@davidzollo davidzollo linked an issue Jul 30, 2020 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
good job, small changes, no need more people review

@davidzollo davidzollo added the enhancement New feature or request label Jul 30, 2020
@davidzollo davidzollo added this to the 1.4.0 milestone Jul 30, 2020
@davidzollo davidzollo merged commit a532d8e into apache:dev Jul 30, 2020
@yangyichao-mango yangyichao-mango deleted the feature-3338 branch July 31, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[But][ui] No warning when user do not fill the node blank

2 participants