Skip to content

[Fix][server&api&worker] Fix add ZOOKEEPER_ROOT env in k8s deploy#3260

Merged
qiaozhanwei merged 1 commit intoapache:devfrom
rockxsj:zk-root
Aug 10, 2020
Merged

[Fix][server&api&worker] Fix add ZOOKEEPER_ROOT env in k8s deploy#3260
qiaozhanwei merged 1 commit intoapache:devfrom
rockxsj:zk-root

Conversation

@rockxsj
Copy link
Copy Markdown
Contributor

@rockxsj rockxsj commented Jul 21, 2020

Tips

What is the purpose of the pull request

add ZOOKEEPER_ROOT env in k8s deploy

Brief change log

  • modified: docker/kubernetes/dolphinscheduler/templates/deployment-dolphinscheduler-api.yaml
  • modified: docker/kubernetes/dolphinscheduler/templates/statefulset-dolphinscheduler-master.yaml
  • modified: docker/kubernetes/dolphinscheduler/templates/statefulset-dolphinscheduler-worker.yaml

Verify this pull request

This pull request is code cleanup without any test coverage.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@yangyichao-mango
Copy link
Copy Markdown
Contributor

Hi,

Please change the title according to the pr specifications[1]. Thx a lot~

[1] https://dolphinscheduler.apache.org/zh-cn/docs/development/pull-request.html

@rockxsj rockxsj changed the title add ZOOKEEPER_ROOT env in k8s deploy [Fix][server&api&worker] Fix add ZOOKEEPER_ROOT env in k8s deploy Jul 22, 2020
@rockxsj
Copy link
Copy Markdown
Contributor Author

rockxsj commented Jul 22, 2020

Hi,

Please change the title according to the pr specifications[1]. Thx a lot~

[1] https://dolphinscheduler.apache.org/zh-cn/docs/development/pull-request.html

done

Copy link
Copy Markdown
Contributor

@qiaozhanwei qiaozhanwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@qiaozhanwei qiaozhanwei merged commit 232a244 into apache:dev Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants