[Fix-3236][DagHelper]getFlowNodeListPost/getFlowNodeListPre time complexity O(N^N) #3249
Merged
davidzollo merged 2 commits intoapache:devfrom Jul 22, 2020
Merged
[Fix-3236][DagHelper]getFlowNodeListPost/getFlowNodeListPre time complexity O(N^N) #3249davidzollo merged 2 commits intoapache:devfrom
davidzollo merged 2 commits intoapache:devfrom
Conversation
added 2 commits
July 20, 2020 15:25
…s might solve the problem Change-Id: I07e45c831c7df0089a94a003ca8a2c07e9746892
…s might solve the problem Change-Id: I96f5a8c0ba18656de8981f513470cfdb6bc2f467
|
SonarCloud Quality Gate failed.
|
davidzollo
approved these changes
Jul 22, 2020
Contributor
davidzollo
left a comment
There was a problem hiding this comment.
+1
thanks for your first contribution, looking forward to your deep participation,thx
Contributor
|
By the way, you should add unit test next time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tips
What is the purpose of the pull request
[DagHelper]getFlowNodeListPost/getFlowNodeListPre time complexity is O(N^N); Thiss might solve the problem
Brief change log
Add vistied marked list to function getFlowNodeListPost/getFlowNodeListPre
Verify this pull request