[Fix] [Server] Fix the spell error and add log in SqlTask#3243
[Fix] [Server] Fix the spell error and add log in SqlTask#3243gabry-lab merged 3 commits intoapache:devfrom zixi0825:fix_spell_error_and_add_log
Conversation
|
LGTM. |
|
Hi,
1.用户除了使用webui,也可以使用api直接创建,除此之外可以将将json序列化过程中出错导致的null值给解决。这里判断是否为null,可以增强代码鲁棒性。举例:虽然一个string的值不可能为null,我们通常使用的StringUtils.isNotEmpty中依然加了null值判断。 If you have any question or suggestion, welcome to put forward~ |
|
If SqlParameters is judged to be null, are all abstractparameters required? If so, they need to be abstracted如果SqlParameters判断为空,那么是不是所有的 AbstractParameters的都需要,如果是,就需要抽象出来 |
I agree with you, if you are interested in this, I think it is better to create an issue and describe all the situation, this pr is just for spell error and some log info. Thx a lot~ |
...heduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sql/SqlTask.java
Outdated
Show resolved
Hide resolved
...heduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sql/SqlTask.java
Outdated
Show resolved
Hide resolved
…duler into fix_spell_error_and_add_log
|
Kudos, SonarCloud Quality Gate passed!
|
What is the purpose of the pull request
This pull request fix the spell error 、add log in SqlTask and add null judgment in SqlTask
Brief change log
Verify this pull request
none