Skip to content

[Improvement][Server]Code Clean#3196

Merged
davidzollo merged 3 commits intoapache:devfrom
CalvinKirs:remote
Jul 12, 2020
Merged

[Improvement][Server]Code Clean#3196
davidzollo merged 3 commits intoapache:devfrom
CalvinKirs:remote

Conversation

@CalvinKirs
Copy link
Copy Markdown
Member

@CalvinKirs CalvinKirs commented Jul 12, 2020 •
edited
Loading

What is the purpose of the pull request

There are some methods in ZookeeperNodeManager Class, these methods define local variables, but they have never been used, so I removed it

Verify this pull request

This pull request is already covered by existing tests, such as (please describe tests).

@yangyichao-mango
Copy link
Copy Markdown
Contributor

yangyichao-mango commented Jul 12, 2020

Hi,

LGTM, is it better to change the title to [Improvement][Server] Code Clean?
If you have any question or suggestion, please put forward.
Thx a lot.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jul 12, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@CalvinKirs CalvinKirs changed the title [*][Server]Code Clean [Improvement][Server]Code Clean Jul 12, 2020
@CalvinKirs
Copy link
Copy Markdown
Member Author

CalvinKirs commented Jul 12, 2020

Hi,

LGTM, is it better to change the title to [Improvement][Server] Code Clean?
If you have any question or suggestion, please put forward.
Thx a lot.

Thanks for your advice.

davidzollo
davidzollo approved these changes Jul 12, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
good job

@davidzollo davidzollo added the enhancement New feature or request label Jul 12, 2020
@davidzollo davidzollo merged commit 933a67d into apache:dev Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidzollo davidzollo davidzollo approved these changes

@yangyichao-mango yangyichao-mango yangyichao-mango approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CalvinKirs @yangyichao-mango @davidzollo