[Bug-3187]close Heartbeat thread pool when MasterRegistry unRegistry#3188
Merged
qiaozhanwei merged 4 commits intoapache:devfrom Jul 13, 2020
Merged
[Bug-3187]close Heartbeat thread pool when MasterRegistry unRegistry#3188qiaozhanwei merged 4 commits intoapache:devfrom
qiaozhanwei merged 4 commits intoapache:devfrom
Conversation
CalvinKirs
reviewed
Jul 10, 2020
Comment on lines
+145
to
+147
| public ScheduledExecutorService getHeartBeatExecutor() { | ||
| return heartBeatExecutor; | ||
| } |
Member
There was a problem hiding this comment.
It’s a bit redundant here. If it’s just for testing, I don’t think it’s necessary.
Contributor
There was a problem hiding this comment.
It’s a bit redundant here. If it’s just for testing, I don’t think it’s necessary.
I agree with @CalvinKirs .
...-server/src/main/java/org/apache/dolphinscheduler/server/master/registry/MasterRegistry.java
Outdated
Show resolved
Hide resolved
Contributor
|
Hi, Good job, LGTM. |
yangyichao-mango
approved these changes
Jul 11, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #3187
Tips
What is the purpose of the pull request
(For example: This pull request adds checkstyle plugin.)
Brief change log
Close Heartbeat thread pool when MasterRegistry unRegistry.
Add unit test
Verify this pull request
(Please pick either of the following options)
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)