Skip to content

Modify the AWS S3 request encryption method to V4.#3182

Merged
davidzollo merged 1 commit intoapache:devfrom
rockxsj:dev
Jul 11, 2020
Merged

Modify the AWS S3 request encryption method to V4.#3182
davidzollo merged 1 commit intoapache:devfrom
rockxsj:dev

Conversation

@rockxsj
Copy link
Copy Markdown
Contributor

@rockxsj rockxsj commented Jul 10, 2020

Tips

What is the purpose of the pull request

fix the bug #3181

Brief change log

dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/HadoopUtils.java

Verify this pull request

This pull request is already covered by existing tests, such as (please describe tests).
HadoopUtilsTest.java have cover the tests.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #3182 into dev will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #3182      +/-   ##
============================================
- Coverage     33.56%   33.52%   -0.05%     
+ Complexity     2398     2395       -3     
============================================
  Files           442      442              
  Lines         20612    20613       +1     
  Branches       2525     2525              
============================================
- Hits           6919     6910       -9     
- Misses        13032    13044      +12     
+ Partials        661      659       -2     
Impacted Files Coverage Δ Complexity Δ
.../org/apache/dolphinscheduler/common/Constants.java 83.33% <ø> (ø) 1.00 <0.00> (ø)
...che/dolphinscheduler/common/utils/HadoopUtils.java 33.82% <0.00%> (-0.17%) 21.00 <0.00> (ø)
...he/dolphinscheduler/common/enums/SqoopJobType.java 0.00% <0.00%> (-88.89%) 0.00% <0.00%> (-3.00%)
...inscheduler/common/task/sqoop/SqoopParameters.java 74.00% <0.00%> (-2.00%) 25.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e7582e...72198cc. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@davidzollo
Copy link
Copy Markdown
Contributor

thanks for your first contribution, if you need help, please send mail to dev@dolphinscheduler.apache.org or my wechat(510570367). when added, please tell my your github id, thx

looking forward for your next contribution

@davidzollo davidzollo merged commit dcdd7de into apache:dev Jul 11, 2020
@rockxsj
Copy link
Copy Markdown
Contributor Author

rockxsj commented Jul 11, 2020

I have already in the wechat dev group,my id is:你这有点弱

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants