Word spelling modification,Comment modification,Log level modification#3180
Merged
davidzollo merged 16 commits intoapache:devfrom Jul 12, 2020
Merged
Word spelling modification,Comment modification,Log level modification#3180davidzollo merged 16 commits intoapache:devfrom
davidzollo merged 16 commits intoapache:devfrom
Conversation
Comment modification Word spelling modification,Comment modification,Log level modification
Codecov Report
@@ Coverage Diff @@
## dev #3180 +/- ##
============================================
- Coverage 33.52% 33.51% -0.01%
+ Complexity 2395 2394 -1
============================================
Files 442 442
Lines 20613 20613
Branches 2525 2525
============================================
- Hits 6910 6908 -2
- Misses 13044 13046 +2
Partials 659 659
Continue to review full report at Codecov.
|
CalvinKirs
reviewed
Jul 11, 2020
Comment on lines
86
to
92
| if (retMaps == null) { | ||
| alertDao.updateAlert(AlertStatus.EXECUTION_FAILURE, "alert send error", alert.getId()); | ||
| logger.info("alert send error : return value is null"); | ||
| logger.error("alert send error : return value is null"); | ||
| } else if (!Boolean.parseBoolean(String.valueOf(retMaps.get(Constants.STATUS)))) { | ||
| alertDao.updateAlert(AlertStatus.EXECUTION_FAILURE, String.valueOf(retMaps.get(Constants.MESSAGE)), alert.getId()); | ||
| logger.info("alert send error : {}", retMaps.get(Constants.MESSAGE)); | ||
| logger.error("alert send error : {}", retMaps.get(Constants.MESSAGE)); | ||
| } else { |
Member
There was a problem hiding this comment.
Looks good to me,This log level, please trouble confirm it again. @dailidong
Contributor
|
+1 |
yangyichao-mango
approved these changes
Jul 11, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1、Word spelling modification “receviers”
2、Comment modification
3、Log level modification